chore: Improves the flow to create a new chart #16252
Conversation
|
/testenv up |
Codecov Report
@@ Coverage Diff @@
## master #16252 +/- ##
==========================================
- Coverage 76.73% 76.73% -0.01%
==========================================
Files 997 997
Lines 53230 53236 +6
Branches 6771 6774 +3
==========================================
+ Hits 40844 40848 +4
- Misses 12156 12158 +2
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@michael-s-molina Ephemeral environment spinning up at http://34.220.235.176:8080. Credentials are |
|
Can we add this step check mark to other flow related modal, where requisites are required for proceeding ? like db connection, filter modal maybe? |
|
Looking good! I look forward to more usability improvements here yet to come (double-click a viz to create, tabbing to inputs, arrow key navigation, etc). This is a great step toward making the feature more approachable. Nice work! |
|
Ephemeral environment shutdown and build artifacts deleted. |
* master: chore(pylint): Reenable ungrouped-imports check (#16256) chore(pylint): Re-enable super-with-arguments check (#16138) fix: disable text reports for now (#16257) fix: pivot col names in post_process (#16262) chore: Improves the flow to create a new chart (#16252) Move pagination outside of table (#16232)
* chore: Improves the flow to create a new chart * Adds a comment about selector specificity
* chore: Improves the flow to create a new chart * Adds a comment about selector specificity
mistercrunch
added
🏷️ bot
SUMMARY
Improves the flow to create a new chart by adding step indicators, tip messages, and feedback to the user when a step is completed.
#16173 has the full thread of discussion that motivated this PR. Hat tip to @ktmud and @junlincc for the excellent improvement ideas.
Closes #16173
Follow-up of #16200
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-13.at.3.41.34.PM.mov
Screen.Recording.2021-08-13.at.3.33.21.PM.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION