-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pivot col names in post_process #16262
fix: pivot col names in post_process #16262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16262 +/- ##
==========================================
- Coverage 76.72% 76.48% -0.25%
==========================================
Files 997 997
Lines 53241 53239 -2
Branches 6772 6772
==========================================
- Hits 40849 40718 -131
- Misses 12162 12291 +129
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* master: chore(pylint): Reenable ungrouped-imports check (#16256) chore(pylint): Re-enable super-with-arguments check (#16138) fix: disable text reports for now (#16257) fix: pivot col names in post_process (#16262) chore: Improves the flow to create a new chart (#16252) Move pagination outside of table (#16232)
(cherry picked from commit 542b864)
(cherry picked from commit 542b864)
Yes, I agree totally with you @Kingflyinger, the "Totals" should use the same aggregation logic as the cell values. This has come up a few times but didn't yet get addressed, and requires some additional logic in the query layer that might take some time to implement (we have to issue a separate query for each layer of totals/subtotals). Do you mind opening an issue here so we can get it prioritized and assigned when the right time comes along? |
SUMMARY
This fix some bugs in the pivot table post processing.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION