Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake): Snowflake dynamic form #16861

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

This is the first stage of making snowflake available as a dynamic form. It adds the fields into the Database Connection Form. Though some refactoring needs to happen to make the sheet more elegant.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-09-27 at 5 30 55 PM

### TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh merged commit b071881 into apache:pexdax/snowflake Sep 27, 2021
hughhhh added a commit that referenced this pull request Oct 17, 2021
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (#16934)

* add logic to check for required fields (#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (apache#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (apache#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (apache#16934)

* add logic to check for required fields (apache#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants