-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(DB Connections): Build Snowflake Dynamic Form #16875
refactor(DB Connections): Build Snowflake Dynamic Form #16875
Conversation
6cd3cc4
to
14ae966
Compare
Codecov Report
@@ Coverage Diff @@
## pexdax/snowflake #16875 +/- ##
====================================================
- Coverage 76.82% 76.78% -0.04%
====================================================
Files 1021 1022 +1
Lines 54903 54899 -4
Branches 7487 7488 +1
====================================================
- Hits 42179 42154 -25
- Misses 12477 12498 +21
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
copyPaste, | ||
} | ||
|
||
export const accountField = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets split these out into individual files
14ae966
to
8ab698b
Compare
8ab698b
to
e4410c5
Compare
023c811
to
c742f99
Compare
c742f99
to
418a9d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just clean up the import
@@ -55,7 +55,7 @@ import { | |||
import Loading from 'src/components/Loading'; | |||
import ExtraOptions from './ExtraOptions'; | |||
import SqlAlchemyForm from './SqlAlchemyForm'; | |||
import DatabaseConnectionForm from './DatabaseConnectionForm'; | |||
import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename /DatabaseConnectionForm/DatabaseConnectionForm
to /DatabaseConnectionForm/index.tsx
so we can just import like this:
import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm';
800856f
to
3e7d795
Compare
* update snowflake spec for dyanmic form * feat(snowflake): Snowflake dynamic form (#16861) * snowflake frontend * snowflake frontend * refactor(DB Connections): Build Snowflake Dynamic Form (#16875) * moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput * quick fix * fixed ValidatedInputField (#16934) * add logic to check for required fields (#17022) * fix * fix linting * remove host * Update EncryptedField.tsx Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* update snowflake spec for dyanmic form * feat(snowflake): Snowflake dynamic form (apache#16861) * snowflake frontend * snowflake frontend * refactor(DB Connections): Build Snowflake Dynamic Form (apache#16875) * moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput * quick fix * fixed ValidatedInputField (apache#16934) * add logic to check for required fields (apache#17022) * fix * fix linting * remove host * Update EncryptedField.tsx Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
SUMMARY
This moves all fields that are not in BasicParametersSchema into their own file in order to make DB Connections Form smaller. The reason for doing this because we are going to be parsing Snowflake's sql alchemy uri in order to enable it for the dynamic form.
This PR also builds up build_sql_alchemy_uri, and get_parameters_from_uri in the Snowflake engine spec.
Lastly, as part of a larger refactor of the DB connection form, I created a validatedInputField that is a sort of go to for any basic string fields that we may want to add to the DB Connection Form.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION