refactor(DB Connections): Build Snowflake Dynamic Form #16875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
arash/refactorDBConnections
branch
2 times, most recently
from
6cd3cc4 to
14ae966
Compare
Codecov Report
@@ Coverage Diff @@
## pexdax/snowflake #16875 +/- ##
====================================================
- Coverage 76.82% 76.78% -0.04%
====================================================
Files 1021 1022 +1
Lines 54903 54899 -4
Branches 7487 7488 +1
====================================================
- Hits 42179 42154 -25
- Misses 12477 12498 +21
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
reviewed
Sep 28, 2021
| copyPaste, | ||
| } | ||
|
|
||
| export const accountField = ({ |
There was a problem hiding this comment.
lets split these out into individual files
AAfghahi
force-pushed
the
arash/refactorDBConnections
branch
from
14ae966 to
8ab698b
Compare
AAfghahi
force-pushed
the
arash/refactorDBConnections
branch
from
8ab698b to
e4410c5
Compare
AAfghahi
force-pushed
the
arash/refactorDBConnections
branch
3 times, most recently
from
023c811 to
c742f99
Compare
AAfghahi
force-pushed
the
arash/refactorDBConnections
branch
from
c742f99 to
418a9d6
Compare
AAfghahi
changed the title
hughhhh
requested changes
Sep 30, 2021
| @@ -55,7 +55,7 @@ import { | |||
| import Loading from 'src/components/Loading'; | |||
| import ExtraOptions from './ExtraOptions'; | |||
| import SqlAlchemyForm from './SqlAlchemyForm'; | |||
| import DatabaseConnectionForm from './DatabaseConnectionForm'; | |||
| import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm'; | |||
There was a problem hiding this comment.
Rename /DatabaseConnectionForm/DatabaseConnectionForm to /DatabaseConnectionForm/index.tsx so we can just import like this:
import DatabaseConnectionForm from './DatabaseConnectionForm/DatabaseConnectionForm';
800856f to
3e7d795
Compare
hughhhh
approved these changes
Sep 30, 2021
hughhhh
added a commit
that referenced
this pull request
Oct 17, 2021
* update snowflake spec for dyanmic form * feat(snowflake): Snowflake dynamic form (#16861) * snowflake frontend * snowflake frontend * refactor(DB Connections): Build Snowflake Dynamic Form (#16875) * moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput * quick fix * fixed ValidatedInputField (#16934) * add logic to check for required fields (#17022) * fix * fix linting * remove host * Update EncryptedField.tsx Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* update snowflake spec for dyanmic form * feat(snowflake): Snowflake dynamic form (apache#16861) * snowflake frontend * snowflake frontend * refactor(DB Connections): Build Snowflake Dynamic Form (apache#16875) * moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput * quick fix * fixed ValidatedInputField (apache#16934) * add logic to check for required fields (apache#17022) * fix * fix linting * remove host * Update EncryptedField.tsx Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This moves all fields that are not in BasicParametersSchema into their own file in order to make DB Connections Form smaller. The reason for doing this because we are going to be parsing Snowflake's sql alchemy uri in order to enable it for the dynamic form.
This PR also builds up build_sql_alchemy_uri, and get_parameters_from_uri in the Snowflake engine spec.
Lastly, as part of a larger refactor of the DB connection form, I created a validatedInputField that is a sort of go to for any basic string fields that we may want to add to the DB Connection Form.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION