Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Validation to Snowflake Form [WIP] #17022

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 7, 2021

SUMMARY

Working on it

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title fix: Add Validation to Snowflake Form fix: Add Validation to Snowflake Form [WIP] Oct 7, 2021
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with high confidence 💪

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17022 (76f14a7) into pexdax/snowflake (f7349d7) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           pexdax/snowflake   #17022      +/-   ##
====================================================
- Coverage             77.02%   77.02%   -0.01%     
====================================================
  Files                  1026     1025       -1     
  Lines                 55219    54917     -302     
  Branches               7564     7487      -77     
====================================================
- Hits                  42535    42300     -235     
+ Misses                12435    12375      -60     
+ Partials                249      242       -7     
Flag Coverage Δ
hive 81.42% <22.22%> (-0.04%) ⬇️
javascript 71.15% <ø> (+<0.01%) ⬆️
mysql 81.78% <22.22%> (-0.09%) ⬇️
postgres 81.88% <22.22%> (-0.04%) ⬇️
presto 81.72% <22.22%> (-0.09%) ⬇️
python 82.38% <22.22%> (-0.04%) ⬇️
sqlite 81.49% <22.22%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/snowflake.py 76.10% <12.50%> (-4.27%) ⬇️
superset/databases/commands/validate.py 75.40% <100.00%> (ø)
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 55.26% <0.00%> (-5.61%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 72.97% <0.00%> (-4.26%) ⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx 91.22% <0.00%> (-3.73%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 55.22% <0.00%> (-2.99%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 92.50% <0.00%> (-2.80%) ⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <0.00%> (-2.34%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 88.46% <0.00%> (-0.97%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 86.66% <0.00%> (-0.84%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7349d7...76f14a7. Read the comment docs.

@hughhhh hughhhh merged commit c99ab95 into pexdax/snowflake Oct 8, 2021
hughhhh added a commit that referenced this pull request Oct 17, 2021
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (#16934)

* add logic to check for required fields (#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* update snowflake spec for dyanmic form

* feat(snowflake): Snowflake dynamic form (apache#16861)

* snowflake frontend

* snowflake frontend

* refactor(DB Connections): Build Snowflake Dynamic Form (apache#16875)

* moved all non-BasicParameters into own field

* refactored DB Connection Form made ValidatedInput

* quick fix

* fixed ValidatedInputField (apache#16934)

* add logic to check for required fields (apache#17022)

* fix

* fix linting

* remove host

* Update EncryptedField.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
@mistercrunch mistercrunch deleted the pexdax/snowflake-add-validation branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants