Feature: Filter Box using TextInput #2867 #2868
Conversation
|
thanks, does this PR address #2614? |
|
No it doesn't The textinput version od the components only works for single elemebt you wanto to search for. It doesnt account for multiple values. It might be possible to implement using string split by a delimiter thought |
| elif select_type == 'select': | ||
| return super(FilterBoxViz, self).get_df(query_obj) | ||
| else: | ||
| raise Exception("Invalid select type") |
superset/assets/backendSync.json
Outdated
| "Text Input" | ||
| ] | ||
| ], | ||
| "description": "How to enter de filter input?" |
There was a problem hiding this comment.
This can be improved by some native english speaker :)
| ['select', 'Select'], | ||
| ['text_input', 'Text Input'], | ||
| ], | ||
| description: 'How to enter de filter input?', |
|
So the more I look at this Filter Box component the more I think it needs to be re-written to supports an array of heterogenous filters. I'm thinking that we probably want to reuse the |
|
Is something missing to merge this, beside fixing the conflict issues? I am working on the rebase here: master...eddy-geek:filter_input_box I'm also having the issue with big tables where the SQL query times out... |
|
Warning: this issue has been inactive for 189 days and will be automatically closed on 2018-04-23 if there is no further activity. You can add the |
kristw
added
enhancement:request
This PR implements the feature described in #2867
The idea is to have a param on the FilterBox component that make it render a TextInput instead of a Select combo box.
When this param is set to TextInput the component won't fetch any data from the backend and the user won't be able to see options available.
The use case is when you want to filter based on a long list (my case is hundreds of thousands) and using the Select became very slow to do so.
Appreciate any feedback