-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support archive.none for OSS directory artifacts #6312
Conversation
Signed-off-by: jibuji <sunnypengfei@gmail.com>
Signed-off-by: jibuji <sunnypengfei@gmail.com>
Original review feedback is in #6296 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All feedback in previous review have been addressed.
Thanks. What should I do next? This is my first time to contribute. |
Let's wait for one of the approvers to take another look for any additional feedback before merging. |
Codecov Report
@@ Coverage Diff @@
## master #6312 +/- ##
==========================================
+ Coverage 47.84% 48.95% +1.10%
==========================================
Files 250 252 +2
Lines 15667 18044 +2377
==========================================
+ Hits 7496 8833 +1337
- Misses 7232 8243 +1011
- Partials 939 968 +29
Continue to review full report at Codecov.
|
Signed-off-by: jibuji <sunnypengfei@gmail.com>
@jibuji PR looks good. can you add a test? |
to fix problem: #6293
I have used the following workflow to test, and the result is correct.
Thanks to @terrytangyuan a lot. He helped me to rectify some code, but I failed to commit the PR because my mistake. So, I open this one and commits again.