-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1.4 cherry-pick #6468
Comments
@Bobgy can you mark the ones you needed again please? |
Thanks! nit: What permission do I need to check boxes here? |
@Bobgy I selected it. Do you have any more issues that need to be included in v3.1.4? I am planning to start release tomorrow |
Thanks, I didn't hit any other issues so far. I am just curious, I think some fixes like the following are generally good to have, but they are not picked at the moment. How do you decide? Antoine Dao: fix(emissary): throw argo error on file not exist (fix(emissary): throw argo error on file not exist #6392) b17d1bf Alex Collins: fix(executor): Remove 15s guard for Docker executor. Fixes wait container won't exit #6415 (fix(executor): Remove 15s guard for Docker executor. Fixes #6415 #6427) |
@Bobgy We will go with the below order
|
|
Hi @sarabala1979, I'm still not seeing my fix in #6247 cherrypicked into 3.1.4. |
I did cherry pick and resolve conflict on windows file. Let me check.
…Sent from my iPhone
On Aug 3, 2021, at 7:08 PM, Yuan (Bob) Gong ***@***.***> wrote:
Hi @sarabala1979, I'm still not seeing my fix in #6247 cherrypicked into 3.1.4.
https://github.com/argoproj/argo-workflows/blob/247776d66fa6bf988f861ba82f181e386a972626/workflow/executor/emissary/binary.go#L19
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
@Bobgy I miss understood. I was including Yuan (Bob) Gong: fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts (fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts #6403) 30e2518. |
Yes, it's a different PR. Sorry I split my fix into multiple PRs in the first place. I see it makes it more confusing than necessary. |
Few PRs are already released in v3.1.3. Please select your PR that needs to release in v3.1.4
workflow never reconciled
when using semaphores #6351 (fix(controller): Mark workflows wait for semaphore as pending. Fixes #6351 #6356) 092b427The text was updated successfully, but these errors were encountered: