Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.4 cherry-pick #6468

Closed
8 of 49 tasks
sarabala1979 opened this issue Aug 2, 2021 · 11 comments
Closed
8 of 49 tasks

v3.1.4 cherry-pick #6468

sarabala1979 opened this issue Aug 2, 2021 · 11 comments
Labels
type/feature Feature request

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Aug 2, 2021

Few PRs are already released in v3.1.3. Please select your PR that needs to release in v3.1.4

@sarabala1979 sarabala1979 added the type/feature Feature request label Aug 2, 2021
@alexec
Copy link
Contributor

alexec commented Aug 2, 2021

@Bobgy can you mark the ones you needed again please?

@Bobgy
Copy link
Contributor

Bobgy commented Aug 2, 2021

Thanks!
I was talking about #6247.
It's not in the list.

nit: What permission do I need to check boxes here?

@Bobgy
Copy link
Contributor

Bobgy commented Aug 2, 2021

I want this too

Yuan (Bob) Gong: fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts (fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts #6403) 30e2518

But I think it's already cherry picked

@sarabala1979
Copy link
Member Author

@Bobgy I selected it. Do you have any more issues that need to be included in v3.1.4? I am planning to start release tomorrow

@Bobgy
Copy link
Contributor

Bobgy commented Aug 3, 2021

Thanks, I didn't hit any other issues so far.

I am just curious, I think some fixes like the following are generally good to have, but they are not picked at the moment. How do you decide?

Antoine Dao: fix(emissary): throw argo error on file not exist (fix(emissary): throw argo error on file not exist #6392) b17d1bf

Alex Collins: fix(executor): Remove 15s guard for Docker executor. Fixes wait container won't exit #6415 (fix(executor): Remove 15s guard for Docker executor. Fixes #6415 #6427)

@sarabala1979
Copy link
Member Author

@Bobgy We will go with the below order

  1. Regression issues must be included
  2. Other fixes based on usecase/no of user facing/ user request/ risk factor.

@sarabala1979
Copy link
Member Author

sarabala1979 commented Aug 3, 2021

@Bobgy
Copy link
Contributor

Bobgy commented Aug 4, 2021

Hi @sarabala1979, I'm still not seeing my fix in #6247 cherrypicked into 3.1.4.
https://github.com/argoproj/argo-workflows/blob/v3.1.4/workflow/executor/emissary/binary.go#L19

@sarabala1979
Copy link
Member Author

sarabala1979 commented Aug 4, 2021 via email

@sarabala1979
Copy link
Member Author

@Bobgy I miss understood. I was including Yuan (Bob) Gong: fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts (fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts #6403) 30e2518.
I missed your comment saying the issue is not on the list.
finally, find it 05c901f
somewhat it was missed in 3.1.3 also. I am releasing v3.1.5

@Bobgy
Copy link
Contributor

Bobgy commented Aug 4, 2021

Yes, it's a different PR. Sorry I split my fix into multiple PRs in the first place. I see it makes it more confusing than necessary.
I'll test more cases in the initial PR next time. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants