Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(executor): emissary executor also runs on GKE autopilot #6430

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jul 27, 2021

Update based on #5434 (comment)

Checklist:

Tips:

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Signed-off-by: Yuan Gong <gongyuan94@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #6430 (bc12284) into master (96b165e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6430      +/-   ##
==========================================
+ Coverage   48.74%   48.75%   +0.01%     
==========================================
  Files         253      253              
  Lines       18217    18217              
==========================================
+ Hits         8880     8882       +2     
  Misses       8367     8367              
+ Partials      970      968       -2     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argo/commands/get.go 60.34% <0.00%> (+0.58%) ⬆️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b165e...bc12284. Read the comment docs.

@alexec alexec enabled auto-merge (squash) July 27, 2021 17:18
@alexec alexec merged commit f1792f6 into argoproj:master Jul 27, 2021
This was referenced Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants