Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.3 Cherry-pick #6435

Closed
14 of 39 tasks
sarabala1979 opened this issue Jul 27, 2021 · 9 comments
Closed
14 of 39 tasks

v3.1.3 Cherry-pick #6435

sarabala1979 opened this issue Jul 27, 2021 · 9 comments
Labels
type/feature Feature request
Milestone

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Jul 27, 2021

@sarabala1979 sarabala1979 added the type/feature Feature request label Jul 27, 2021
@alexec
Copy link
Contributor

alexec commented Jul 27, 2021

@terrytangyuan do you want to mark any for OSS?
@tczhao there are a few fixes for GCS is this list. Do you think they should be included?

@alexec
Copy link
Contributor

alexec commented Jul 27, 2021

I'd like to include #6434, once it is merged. @sarabala1979 otherwise I have marked the fixes I want to include

@alexec alexec added this to the v3.1 milestone Jul 27, 2021
@sarabala1979
Copy link
Member Author

sarabala1979 commented Jul 27, 2021

@terrytangyuan
Copy link
Member

Nothing to include for OSS for this release but could you include the following commit?

Yuan Tang: feat(controller): Allow configurable host name label key when retrying different hosts #6341 d6ec032

@tczhao
Copy link
Member

tczhao commented Jul 27, 2021

I'm keen to include the GCS fixes

@alexec
Copy link
Contributor

alexec commented Jul 28, 2021

Released!

@alexec alexec closed this as completed Jul 28, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Aug 1, 2021

Hi @alexec @sarabala1979, I think we missed cherry picking my first PR fix for emissary with nonroot: https://github.com/argoproj/argo-workflows/pull/6247/files. It's also required for running emissary with nonroot containers.

https://github.com/argoproj/argo-workflows/blob/release-3.1/workflow/executor/emissary/binary.go#L19

@alexec alexec reopened this Aug 1, 2021
@sarabala1979
Copy link
Member Author

@terrytangyuan We already released v3.1.3. Which includes only the checked once. Sorry, we missed your comments. you might be commented after we start releasing process. I can do 3.1.4 this week. I will create cherry-pick issue tomorrow.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 1, 2021

No worries, thank you for the quick response! Looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

5 participants