fix(controller): Randomly expr expression fail to resolve #6410
Conversation
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
workflow/common/common.go
Outdated
| @@ -139,7 +139,7 @@ const ( | |||
| // GlobalVarWorkflowDuration is the current duration of this workflow | |||
| GlobalVarWorkflowDuration = "workflow.duration" | |||
| // GlobalVarWorkflowParameters is a JSON string containing all workflow parameters | |||
| GlobalVarWorkflowParameters = "workflow.parameters" | |||
| GlobalVarWorkflowParameters = "workflow.parameters.json" | |||
There was a problem hiding this comment.
Randomly bellows.Expand failed to expend all global variable workflow.parameters.xxx if workflow.parameters expended first. We should have a different name for workflow.parameters json format.
There was a problem hiding this comment.
we should raise a bug with bellows?
There was a problem hiding this comment.
maybe not, I think it does not make sense - but can we make sure that this is not used - new in v3.1?
There was a problem hiding this comment.
also - should work for fasttemplate
There was a problem hiding this comment.
fasttemplate will just string replace. it will work. I can ask the community channel for this variable.
There was a problem hiding this comment.
if it is in v3.0, then changing it would be breaking change
There was a problem hiding this comment.
I think we should exclude this from {{= templates. Users should not need it.
There was a problem hiding this comment.
we can prevent to have {{= in when element. So this is the way when will have only govaluate format.
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6410 +/- ##
==========================================
- Coverage 48.77% 48.77% -0.01%
==========================================
Files 253 253
Lines 18151 18186 +35
==========================================
+ Hits 8854 8870 +16
- Misses 8334 8347 +13
- Partials 963 969 +6
Continue to review full report at Codecov.
|
|
feat: Expose workflow.paramteres with JSON string of all params (#2341) Date to 2020, so can't change name. |
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
closes #6257
Checklist:
Tips:
git commit --signoff.make pre-commit -Bto fix codegen or lint problems.