-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): Same workflow nodes are not executing parallel even semaphore locks available #6418
Conversation
…maphore Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6418 +/- ##
==========================================
- Coverage 48.81% 48.67% -0.14%
==========================================
Files 253 253
Lines 18153 18223 +70
==========================================
+ Hits 8861 8870 +9
- Misses 8324 8385 +61
Partials 968 968
Continue to review full report at Codecov.
|
@@ -165,7 +176,8 @@ func (s *PrioritySemaphore) tryAcquire(holderKey string) (bool, string) { | |||
if s.pending.Len() > 0 { | |||
item := s.pending.peek() | |||
nextKey = fmt.Sprintf("%v", item.key) | |||
if holderKey != nextKey { | |||
if holderKey != nextKey && !isSameWorkflowNodeKeys(holderKey, nextKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to prioritize/order the same workflow nodes. The executetemplate will make sure the template order.
if the workflow has multiple nodes to wait for lock, the operator node order and semaphore queue order are going out of sync. if it same workflow key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clean-up PR
done. I missed to cleanup my env |
…semaphore locks available (#6418) * fix(controller): Same workflow nodes are not executing parallel in semaphore
closes #6110
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
Checklist:
Tips:
git commit --signoff
.make pre-commit -B
to fix codegen or lint problems.