Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_vehicle_info_utils): replace autoware_universe_utils with autoware_utils #10167

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Feb 19, 2025

Description

This PR replaces autoware_universe_utils with autoware_utils in autoware_vehicle_info_utils as preparation of porting to Autoware Core.

This also includes the following modification in order to pass the build CI:

  • make autoware::universe_utils::Point2d and autoware_utils::Point2d compatible 59f8629
  • modify packages that depend on autoware_universe_utils via autoware_vehicle_info_utils to make sure that they independently include autoware_unvierse_utils headers. 439a979

Related links

Parent Issue:

** Related PRs **

How was this PR tested?

https://evaluation.ci.tier4.jp/evaluation/reports/e1e201aa-8dbe-53a6-900a-4255276fa924?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Feb 19, 2025
Copy link

github-actions bot commented Feb 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.80%. Comparing base (3fd5f8c) to head (e6809b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rture_checker_node/lane_departure_checker_node.cpp 0.00% 2 Missing ⚠️
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 2 Missing ⚠️
...e_control_evaluator/src/control_evaluator_node.cpp 0.00% 1 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10167      +/-   ##
==========================================
+ Coverage   26.75%   26.80%   +0.05%     
==========================================
  Files        1402     1403       +1     
  Lines      108063   108076      +13     
  Branches    41609    41613       +4     
==========================================
+ Hits        28912    28975      +63     
+ Misses      76274    76217      -57     
- Partials     2877     2884       +7     
Flag Coverage Δ *Carryforward flag
differential 29.94% <53.84%> (?)
total 26.75% <ø> (-0.01%) ⬇️ Carriedforward from 3fd5f8c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r changed the title feat: replace autoware_universe_utils with autoware_utils in autoware_vehicle_info_utils feat(autoware_vehicle_info_utils): replace autoware_universe_utils with autoware_utils Feb 20, 2025
@mitsudome-r
Copy link
Member Author

Waiting for approval for: https://github.com/tier4/vehicle2infrastructure/pull/123

mitsudome-r and others added 4 commits February 20, 2025 21:28
…th autoware_utils

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
…utils

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the replace-autoware-utils-vehicle-info-utils branch from e70b3e9 to e6809b3 Compare February 20, 2025 12:28
@mitsudome-r mitsudome-r merged commit 6d0788b into autowarefoundation:main Feb 20, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants