Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove launch for old routing api #2136

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 24, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Remove launch for old routing api node.
tier4/tier4_ad_api_adaptor#75

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) November 9, 2022 09:13
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 10.48% // Head: 10.48% // No change to project coverage 👍

Coverage data is based on head (12fbe87) compared to base (12fbe87).
Patch has no changes to coverable lines.

❗ Current head 12fbe87 differs from pull request most recent head 1ab2485. Consider uploading reports for the commit 1ab2485 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2136   +/-   ##
=======================================
  Coverage   10.48%   10.48%           
=======================================
  Files        1249     1249           
  Lines       90870    90870           
  Branches    20843    20843           
=======================================
  Hits         9527     9527           
  Misses      71219    71219           
  Partials    10124    10124           
Flag Coverage Δ
total 10.46% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r force-pushed the feature/ad-api/remove-old-routing-launch branch from 5171e54 to 3eafc17 Compare November 18, 2022 06:22
@mitsudome-r mitsudome-r requested a review from a team as a code owner November 18, 2022 06:22
@mitsudome-r mitsudome-r force-pushed the feature/ad-api/remove-old-routing-launch branch from 3eafc17 to 1ab2485 Compare November 18, 2022 06:48
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the feature/ad-api/remove-old-routing-launch branch from 1ab2485 to b95d136 Compare November 18, 2022 10:05
@isamu-takagi isamu-takagi merged commit aa62853 into autowarefoundation:main Nov 18, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/remove-old-routing-launch branch November 18, 2022 10:35
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants