Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply adapi routing #75

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Oct 24, 2022

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#2136
tier4/autoware_launch#526

Description

Apply AD API (routing).

Review Procedure

Check if the following APIs work.

  • /api/external/set/route
  • /api/external/get/route

Remarks

Sample command.

ros2 service call /api/external/set/route tier4_external_api_msgs/srv/SetRoute "
route:
  goal_pose:
    header:
      stamp:
        sec: 1666590752
        nanosec: 356599301
      frame_id: map
    pose:
      position:
        x: 3797.385498046875
        y: 73762.9921875
        z: 19.400703706523093
      orientation:
        x: 0.0
        y: 0.0
        z: 0.232341862771554
        w: 0.9726341855003063
  route_sections:
  - {preferred_lane_id: 9540, lane_ids: [9540]}
  - {preferred_lane_id: 9546, lane_ids: [9546]}
  - {preferred_lane_id: 9178, lane_ids: [9178]}
  - {preferred_lane_id: 52,   lane_ids: [52]}
  - {preferred_lane_id: 124,  lane_ids: [124]}"

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
@isamu-takagi isamu-takagi enabled auto-merge (squash) November 9, 2022 09:12
@tkhmy
Copy link
Contributor

tkhmy commented Nov 17, 2022

The set/goal is been removed, need to replace the service to /api/routing/set_route_points
Will review this PR after I make the implementation on the application

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested in application

@isamu-takagi isamu-takagi merged commit c515822 into tier4/universe Nov 18, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/routing branch November 18, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants