Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_rviz_plugin): rviz object covariances #6074

Merged

fix: confidence interval (1D) and confidence region (2D)

fd81b7f
Select commit
Loading
Failed to load commit list.
Merged

feat(perception_rviz_plugin): rviz object covariances #6074

fix: confidence interval (1D) and confidence region (2D)
fd81b7f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 16, 2024 in 55s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 4 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method predicted_objects_display.cpp: PredictedObjectsDisplay::createMarkers
  • Complex Method tracked_objects_display.cpp: TrackedObjectsDisplay::processMessage
  • Complex Method detected_objects_display.cpp: DetectedObjectsDisplay::processMessage
  • Primitive Obsession object_polygon_detail.cpp

Annotations

Check warning on line 1 in common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Primitive Obsession

In this module, 33.3% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check warning on line 227 in common/autoware_auto_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

PredictedObjectsDisplay::createMarkers increases in cyclomatic complexity from 16 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 204 in common/autoware_auto_perception_rviz_plugin/src/object_detection/tracked_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrackedObjectsDisplay::processMessage increases in cyclomatic complexity from 12 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 154 in common/autoware_auto_perception_rviz_plugin/src/object_detection/detected_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

DetectedObjectsDisplay::processMessage has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.