fix: the stopping speed judgments of freespace_planner and mission_planner #7859
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try110
requested review from
kosuke55,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Try110
changed the title
Try110
changed the title
…nner are consistent, taking into account the speed in xyz direction Signed-off-by: yangzesong <15340400289@163.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. |
mitsudome-r
reviewed
Dec 17, 2024
planning/autoware_freespace_planner/src/autoware_freespace_planner/freespace_planner_node.cpp
Outdated
Show resolved
Hide resolved
…nner/freespace_planner_node.cpp fix: removed redundant abs functions Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… are consistent, taking into account the speed in xyz direction
Description
The stopping speed judgments of freespace_planner and mission_planner are consistent, taking into account the speed in xyz direction
Related links
#7834
How was this PR tested?
None
Notes for reviewers
This is an accidental bug. The conditions for judging the end of a task are looser than the conditions for judging the completion of a task are used by the mission_planner, which occasionally causes the freespace_planner to judge that the task is completed, but the mission_planner to judge that the task is not completed.
Interface changes
None.
Effects on system behavior
None.