Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change ml models location #938

Merged
merged 11 commits into from
May 27, 2022
Merged

chore: change ml models location #938

merged 11 commits into from
May 27, 2022

Conversation

eratostennis
Copy link
Contributor

Description

Change ml models location from google drive to AWS s3 in order to solve the following problem.
autowarefoundation/autoware#2433

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@eratostennis eratostennis requested a review from yukke42 May 20, 2022 02:25
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #938 (8ab283c) into main (0e6dd1b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #938   +/-   ##
=====================================
  Coverage   9.54%   9.54%           
=====================================
  Files        941     941           
  Lines      58334   58334           
  Branches   10577   10577           
=====================================
  Hits        5570    5570           
  Misses     48045   48045           
  Partials    4719    4719
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.54% <ø> (ø) Carriedforward from 0e6dd1b

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6dd1b...8ab283c. Read the comment docs.

@wep21 wep21 requested a review from yukkysaito May 20, 2022 02:42
@wep21
Copy link
Contributor

wep21 commented May 20, 2022

It may be more simple to use file(DOWNLOAD).

@wep21 wep21 requested a review from kenji-miyake May 20, 2022 02:45
@eratostennis
Copy link
Contributor Author

It may be more simple to use file(DOWNLOAD).

@wep21
I fixed it. Please review again.
Thanks.

@wep21 wep21 requested review from wep21 and aohsato May 26, 2022 22:08
wep21
wep21 approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 self-requested a review May 27, 2022 00:35
wep21
wep21 requested changes May 27, 2022
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eratostennis Could you make timeout time longer for huge models?

@eratostennis
Copy link
Contributor Author

@eratostennis Could you make timeout time longer for huge models?

@wep21 I fixed it.

@wep21 wep21 self-requested a review May 27, 2022 02:15
wep21
wep21 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 5cca477 into autowarefoundation:main May 27, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request May 28, 2022
Merged
@yukke42 yukke42 mentioned this pull request Jun 3, 2022
Merged
7 tasks
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
@eratostennis @wep21 @ktro2828
chore: change ml models location (autowarefoundation#938)
ddd1f60 
* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: adjust time out prediod

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@eratostennis @wep21 @boyali
chore: change ml models location (tier4#938)
9bfacc5 
* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: adjust time out prediod

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@eratostennis @wep21 @boyali
chore: change ml models location (tier4#938)
3b5cd29 
* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: adjust time out prediod

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@eratostennis @wep21 @boyali
chore: change ml models location (tier4#938)
0ccb36c 
* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: adjust time out prediod

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@eratostennis @wep21 @boyali
chore: change ml models location (tier4#938)
8d819fe 
* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: change ml models location

* refactor: model download method

* refactor: use message instead of echo

* refactor: remove unused code and set timeout for downloading

* chore: adjust time out prediod

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Oct 17, 2023
@rej55 @zulfaqar-azmi-t4
fix(lane_change): prevent node from dying for trimmed shifted path (a…
9c8a797 
…utowarefoundation#5271) (autowarefoundation#938)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
@OsamuSekino @1222-takeshi
feat: add cyclonedds priority param (autowarefoundation#938)
9e5e08a 
add cyclonedds priority param
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
@TomohitoAndo
chore: add option to select graph path depending on running mode (aut…
7a65bc9 
…owarefoundation#938)

chore: add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 approved these changes

@yukke42 yukke42 Awaiting requested review from yukke42

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@aohsato aohsato Awaiting requested review from aohsato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eratostennis @wep21