Clean cache directory after use #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again. Will fold these into a new patch in the next couple of days. |
|
Looks like there is a regression test failure I will need to look into to see if it is valid or not before patching. |
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By splitting the restore and save steps of the cache action, we can run some steps after the post cache step which otherwise would be run at the end of the workflow.
This allows us to clean the cache directory after it has been saved. This fixes #94, allows us to save the cache even if the rest of the workflow fails and also has the minor benefit of reduced disk usage.
Differences for existing workflows:
~/cache-apt-pkgsdirectory being present (you shouldn't).