Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install apt-fast from source if not present #97

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Only install apt-fast from source if not present #97

merged 2 commits into from
Mar 8, 2023

Conversation

pascallj
Copy link
Contributor

@pascallj pascallj commented Mar 7, 2023

Install apt-fast only from source when it is not present as it is already included in all of the Ubuntu runner images but might not be on custom runners.

Fixes: #96 (comment)

Test with apt-fast present and test without apt-fast present.

@mstruebing
Copy link

Thank you for implementing this so quickly

@awalsh128 awalsh128 merged commit bdc0928 into awalsh128:master Mar 8, 2023
@awalsh128
Copy link
Owner

Appreciate the community help.

awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants