Don't install apt-fast from source #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Hey there, we were just testing your action but we are using custom runners with custom runner images. If you like that idea, I would try to make a PR with that change. |
|
You're right, custom runners are also a thing. There is no need to implement an extra argument for that. We can easily detect if |
awalsh128
pushed a commit
that referenced
this pull request
Mar 8, 2023
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128
added a commit
that referenced
this pull request
Mar 24, 2023
* More robust checking of age of apt cache (#90) * Don't install apt-fast from source (#96) * Clean cache directory after use (#95) * Only install apt-fast from source if not present (#97) * Revert "Don't install apt-fast from source (#96)" This reverts commit 854bb53. * Only install apt-fast from source if not present --------- Co-authored-by: John Hughes <jondo2010@gmail.com> Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to install
apt-fastfrom source as it is already included in all of the Ubuntu runner images.