Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AMD PMC/U support #222

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Add AMD PMC/U support #222

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
411112c
Add AMD PMC/U support
lancelui-amzn Aug 6, 2024
b823522
clearer event labels, fixed l3 misses
lancelui-amzn Aug 7, 2024
5cc4e58
sum backend stall counters on milan
lancelui-amzn Aug 7, 2024
82c2f8f
rustfmt change
lancelui-amzn Aug 7, 2024
d1ee8e0
rename stall backend on milan
lancelui-amzn Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/data/amd_milan_perf_events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,11 @@ static CYCLES: NamedTypeCtr = NamedTypeCtr {
lazy_static! {
pub static ref MILAN_CTRS: Vec<NamedCtr<'static>> = [
NamedCtr {
name: "stall_backend_pkc1",
nrs: vec![STALL_BACKEND_1],
name: "stall_backend",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it still have the pkc in its name? Do whatever we do for other processors on this metric.

But having a metric without showing what its units/scale are seems incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right.

nrs: vec![STALL_BACKEND_1, STALL_BACKEND_2],
drs: vec![CYCLES],
scale: 1000
},
NamedCtr {
name: "stall_backend_pkc2",
nrs: vec![STALL_BACKEND_2],
drs: vec![CYCLES],
scale: 1000
},
}
]
.to_vec();
}
Loading