Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): populate variants in endpoints hashes #2974

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 2, 2021

Issue

Internal JS-2908

Follow-up to #2947
Cleaned up PR of #2962

Note: This PR will be rebased from main and made ready after #2962 is merged. PR is ready!

Description

Populates variants in endpoints hashes:

  • The hostname and variants are now compulsory keys for RegionHash and PartitionHash.
    • The hostname can be removed, after we’ve completely switched to variants.
  • The variants array is populated with default hostname with no tags.
    • This will make utilities in config-resolver simpler, as we can ignore hostname and process just the variants.

Testing

N/A as variants are additive. The functional tests are successful.
The follow-up PRs will update unit tests in config-resolver, and affected middleware packages.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #2974 (6d2bf78) into main (55f4e85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2974   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         566      566           
  Lines       30315    30315           
  Branches     7460     7460           
=======================================
  Hits        17796    17796           
  Misses      12519    12519           
Impacted Files Coverage Δ
...lients/client-lex-runtime-service/src/endpoints.ts 100.00% <ø> (ø)
clients/client-mediastore-data/src/endpoints.ts 100.00% <ø> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <ø> (ø)
clients/client-sts/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-ec2/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json-10/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-query/src/endpoints.ts 100.00% <ø> (ø)
...rivate/aws-protocoltests-restjson/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-restxml/src/endpoints.ts 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f4e85...6d2bf78. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP November 2, 2021 21:26
@trivikr trivikr marked this pull request as draft November 2, 2021 21:26
@trivikr trivikr force-pushed the populate-variants-endpoint-hashes-final branch from 6d2bf78 to 020d749 Compare November 2, 2021 22:32
@trivikr trivikr marked this pull request as ready for review November 2, 2021 22:33
@trivikr trivikr changed the title chore(clients): populate variants in endpoints hashes feat(clients): populate variants in endpoints hashes Nov 2, 2021
@trivikr trivikr merged commit 0dd68ef into aws:main Nov 2, 2021
@trivikr trivikr deleted the populate-variants-endpoint-hashes-final branch November 2, 2021 23:29
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants