-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make badge colors more consistent #20
Conversation
This changes the green, yellow, red and gray badges to match each other, using the Travis badges' colors as reference. The 1.0 and 3.0 Code Climate badge colors were determined using the midpoints between 0.0, 2.0 and 4.0. Consistency is key!
👍 It makes more sense. Though, some people advocates for more flashy colors :) But that's another issue |
I assumed that the PNG images were just snapshots of the PSD but apparently, I clobbered changes that hadn't made their way into the PSD, like changing "GPA" to "code climate," etc. Still, the PNG diffs are useful for seeing color changes. |
Flashier is fine by me, but I wanted to start with consistency. 😄 |
I should also mention that I cleaned up the PSD a bit while I was in there. Nothing major. I have more cleanups in mind that should be done but I'll post those as an issue. I didn't touch the 2x PSD or images because I just wanted to get some opinions on the changes first. |
While I'm okay with standardizing colors, not so fond of the yellow-green shade. Most of everything is being done through the SVGs and then exported out as PNGs. The PSD is a little outdated at this point. I've been letting @olivierlacan handle the visual design stuff, I've just been doing the technical work for vectors, so I'll let him give his input on color scheming before moving forward on this. |
@laserlemon I'm going to merge this in because it's a PITA to check the PSD on your end (private fork? my brain has been on too long?) and I want to peek at it before @sferik's #23 blows it all to hell. Remember to put a little preview in the PR next time so we can keep track of iterations. 😺 PS: the text changes to the PSD didn't matter, it was just a reference implementation. |
Make badge colors more consistent
@olivierlacan I'm fine with "sunnier greens", I'm saying that @laserlemon's yellow-green (on the old GPA 3.0 badge) doesn't work so well. Almost looks like brown. |
This changes the green, yellow, red and gray badges to match each other,
using the Travis badges' colors as reference. The 1.0 and 3.0 Code
Climate badge colors were determined using the midpoints between 0.0,
2.0 and 4.0.
Consistency is key!