-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make passing Travis badge bright green #22
Conversation
I wanted to compare the output of your version: and the previous one: This is straight out of Chrome. Aside from the font issue @ackerdev was dealing with, the text is clearly one "pixel" too high, no? |
Color accuracy in browsers is making me 😡. |
I see what you’re saying but nudging it down a pixel would put the “g”’s descender pretty close to the bottom. You’re probably right but I’d need to see the variations next to each other before I know for sure. |
Might want to take a look at #15, @afeld seems to have found a solution for rendering out PNGs that doesn't look to suck so bad. I haven't gotten the time to try it out myself but I do know that outside of text that everything else was rendering properly when I originally tried to convert with imagemagick. His solution should hopefully fix text rendering. Hopefully I can find some time coming up here to recreate the SVGs as a base set of colors and make it easier to hack on, with a guide to convert the svg to png. |
This change has already been merged into the Are you waiting on anything else to merge it in here? |
@sferik The text rendering on that is pretty horrible though, it's affixing itself to solid pixels and causing wonky spacing between letters. Shouldn't have implemented that, imo. |
Yep, that text rendering is all wrong, @ackerdev beat me to it. 😄 |
Wow, you guys are fast. I'll take a look at #15 and see if I can get the kerning fixed. |
Says the guy with his own Doppler effect. 😆 |
Apologies for not noticing the text rendering issue here by the way @sferik, I was flying in to SF yesterday. Tired eyes. |
Alright, fixed the import render, merging this. |
Make passing Travis badge bright green
😊 |
This is the other half of #20. I don't have Adobe Illustrator, so I just edited the SVG file manually and genereated the PNG using this website: http://www.fileformat.info/convert/image/svg2png.htm
When I tried using the
svg2png
command-line utility, it produced this:And when I tried using:
it produced the error:
/cc @laserlemon