Delete Photoshop images 🙅 #23
Merged
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #21.
|
Agreed on removing the Illustrator noise. I was already planning on recreating them from scratch but I was waiting on figuring out a good solution for automation (svg2png/imagemagick convert have quite a bit of obstacles to overcome as you're now seeing in #22) |
ackerdev
added a commit
that referenced
this pull request
Mar 10, 2013
espadrine
added a commit
that referenced
this pull request
Feb 19, 2014
Bitmap images (PNG & friends) are cached in memory. Note: the cache is not discriminatory and grows constantly. Part of issue #23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why (the fuck) should I have to buy a $699 piece of proprietary shitware (that writes proprietary files) to hack on an open source project?
I’d propose that we delete
shields.psdand stick with SVG and PNG images.I’d also propose that we remove Illustrator noise from the SVGs and make sure they can be converted to PNGs using open source tools like
svg2pngorconvert.Branch name courtesy of @nrrrdcore.