Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16204 Fixed slow build #550

Merged
merged 1 commit into from
May 25, 2023
Merged

16204 Fixed slow build #550

merged 1 commit into from
May 25, 2023

Conversation

severinbeauvais
Copy link
Collaborator

Issue #: bcgov/entity#16204

Description of changes:

  • app version = 5.2.6
  • restricted vue version to fix slow/frozen build process
  • fixed max-len warnings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- restricted vue version to fix slow/frozen build process
- fixed max-len warnings
Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #550 (385a477) into main (ad884f5) will decrease coverage by 0.95%.
The diff coverage is 88.53%.

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   85.54%   84.59%   -0.95%     
==========================================
  Files         194      187       -7     
  Lines        4115     3797     -318     
  Branches      672      473     -199     
==========================================
- Hits         3520     3212     -308     
+ Misses        593      561      -32     
- Partials        2       24      +22     
Impacted Files Coverage Δ
src/interfaces/index.ts 100.00% <ø> (ø)
src/store/state/state-model.ts 100.00% <ø> (ø)
src/utils/AxiosInstance.ts 42.85% <0.00%> (+1.19%) ⬆️
src/utils/FetchConfig.ts 3.12% <0.00%> (+1.89%) ⬆️
src/utils/feature-flag-utils.ts 50.00% <ø> (+10.00%) ⬆️
src/mixins/common-mixin.ts 59.18% <60.00%> (+2.32%) ⬆️
src/store/store.ts 77.72% <77.72%> (ø)
src/mixins/people-roles-mixin.ts 76.19% <82.85%> (+1.32%) ⬆️
src/mixins/add-edit-org-person-mixin.ts 74.89% <92.68%> (+0.08%) ⬆️
src/mixins/filing-template-mixin.ts 75.00% <95.27%> (-2.21%) ⬇️
... and 91 more

... and 11 files with indirect coverage changes

@severinbeauvais severinbeauvais merged commit 20b5f56 into bcgov:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants