Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI, Create UI: fix slow builds #16204

Closed
3 tasks done
severinbeauvais opened this issue May 3, 2023 · 2 comments
Closed
3 tasks done

Edit UI, Create UI: fix slow builds #16204

severinbeauvais opened this issue May 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented May 3, 2023

Since some semi-unrelated PRs were linked to this ticket, I update this ticket's ticket, description, etc accordingly, and moved the previous content to #16500.

Travis and I realized that the builds had gotten slow, and sometimes hung, as a result of a recent PR. This ticket is to keep track of that work and time.

  • investigate what impacted the build - I found that a vue package update caused this
  • fix Edit UI accordingly
  • fix Create UI accordingly
@severinbeauvais severinbeauvais added bug Something isn't working ENTITY Business Team labels May 3, 2023
@Mihai-QuickSilverDev Mihai-QuickSilverDev changed the title Edit UI: restoration may be setting date fields incorrection Edit UI: restoration may be setting date fields incorrectly May 4, 2023
@severinbeauvais severinbeauvais self-assigned this May 23, 2023
@severinbeauvais severinbeauvais changed the title Edit UI: restoration may be setting date fields incorrectly Edit UI: full restoration bugs (date fields, approval type) May 23, 2023
@severinbeauvais severinbeauvais changed the title Edit UI: full restoration bugs (date fields, approval type) Edit UI, Create UI: fix slow builds May 25, 2023
@bcgov bcgov deleted a comment from argush3 May 25, 2023
@bcgov bcgov deleted a comment from Mihai-QuickSilverDev May 25, 2023
@bcgov bcgov deleted a comment from Mihai-QuickSilverDev May 25, 2023
@severinbeauvais
Copy link
Collaborator Author

I deleted some obsolete comments from above and updated #16500 accordingly.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented May 25, 2023

Test Notes

There is nothing in particular to test for this. Verifying that the build and unit tests succeed should prove that the code works after these changes.

Note that we were using the current version of vue (2.7.10) for several months without issue, so I think it should still be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

2 participants