Edit UI: full restoration bugs (date fields, approval type) #16500

severinbeauvais · 2023-05-25T00:20:11Z

This is related to #16081 and #16155.

If the todos below get done quickly, see also bugs in #16079 and #16080.

determine if Limited Restoration Conversion to Full is setting dates correctly depending on approval type (eg, registrar)
if limited restoration was done by court order, the conversion can only be done by court order
check whether approval fields are properly saved and resumed
check that validation enforces mandatory fields
check that first invalid section is scrolled to
check that empty fields match schema (eg, field may need to be undefined if empty)
fix any issues
update unit tests

UXPin: https://preview.uxpin.com/306da47387722817e24fc77fd71476a1869a05fe#/pages/160541351/simulate/sitemap

severinbeauvais · 2023-05-25T00:21:37Z

Comment from Argus on May 4, 2023:

@Mihai-QuickSilverDev @severinbeauvais Just did a test for this in DEV and verified that the UI is not passing the gazette publish and application mailed date that were filled out in the conversion application.

FE Http Request Body

PUT https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0871238/filings/144874
Note that values were passed for parties and offices in the body payload but replaced with empty list to help with readability.

{
  "filing": {
    "business": {
      "foundingDate": "2022-11-21T08:04:10.034456+00:00",
      "identifier": "BC0871238",
      "legalName": "0871238 B.C. COMMUNITY CONTRIBUTION COMPANY LTD.",
      "legalType": "CC"
    },
    "header": {
      "certifiedBy": "asdf",
      "date": "2023-05-04",
      "folioNumber": "",
      "name": "restoration",
      "priority": false,
      "waiveFees": true
    },
    "restoration": {
      "approvalType": "registrar",
      "business": {
        "identifier": "BC0871238",
        "legalType": "CC"
      },
      "contactPoint": {
        "email": "snikker298@gmail.com",
        "phone": "(911) 033-7861"
      },
      "nameRequest": {
        "legalName": "0871238 B.C. COMMUNITY CONTRIBUTION COMPANY LTD.",
        "legalType": "CC"
      },
      "offices": [], 
      "parties": [],
      "relationships": [
        "Heir or Legal Representative",
        "Officer"
      ],
      "type": "limitedRestorationToFull"
    }
  }
}

severinbeauvais · 2024-09-11T16:25:24Z

I may have fixed these issues in #16079.

ArwenQin · 2024-09-11T19:17:32Z

@severinbeauvais
For limited restore by Registrar, then convert to full restore, the approval type section shows both types:

But if I choose by court order, while there shows no error, after I click "file and pay", it shows error saying "must choose registrar"

Just to confirm is it a bug, or expected? I assume it's a bug.

ArwenQin · 2024-09-11T19:22:34Z

@severinbeauvais
Just to confirm, Approval Type approved by registrar, can the date the Notice of the Application and date of mailed be in future?

Currently, both dates can be in the future.

severinbeauvais · 2024-09-11T19:28:32Z

@severinbeauvais Just to confirm, Approval Type approved by registrar, can the date the Notice of the Application and date of mailed be in future? Currently, both dates can be in the future.

If you don't see a requirement for this in the UI designs then it's OK.

severinbeauvais · 2024-09-11T19:32:41Z

@severinbeauvais For limited restore by Registrar, then convert to full restore, the approval type section shows both types:
But if I choose by court order, while there shows no error, after I click "file and pay", it shows error saying "must choose registrar"
Just to confirm is it a bug, or expected? I assume it's a bug.

@Mihai-QuickSilverDev , what is the requirement here -- if the limited restoration was done by registrar (not court order), does the conversion to full restoration have to be done by registrar also, or can the conversion be done by court order?

I think the UI design says that the conversion can be done by court order even if the limited restoration was done by registrar. If this is true then this is a Legal API validation bug (new ticket).

Mihai-QuickSilverDev · 2024-09-11T20:25:10Z

Hi Sev, the only restriction is this:

For a Full Restoration - the person requesting the restoration needs to be affiliated in an official position with the company
For a Limited Restoration - the person requesting the restoration does not need to be affiliated in an official position with the company

So, going back to your question, if a company was limited restored by Registrar, that restoration could be converted to a Full one by Court Order, and vice-versa.

severinbeauvais · 2024-09-11T20:37:49Z

So, going back to your question, if a company was limited restored by Registrar, that restoration could be converted to a Full one by Court Order, and vice-versa.

According to the UI design, if the limited restoration was done by Court Order then the conversion must also be done by Court Order. Can you confirm this?

However, it seems accurate that, if the limited restoration was done by Registrar then the conversion could be done by Registrar or Court Order. Because of this, I think we need that Legal API validation ticket. Arwen, can you please create it?

ArwenQin · 2024-09-11T20:46:51Z

Because of this, I think we need that Legal API validation ticket. Arwen, can you please create it?

@severinbeauvais
Yes, I just created # 23251

ArwenQin · 2024-09-11T22:15:35Z

severinbeauvais · 2024-09-11T23:09:07Z

Sounds good.

~~For the first bug, you'll need to fix the component in the bcrs-shared-components repo. I can help you publish it.~~ see next comment

severinbeauvais · 2024-09-12T19:53:54Z

I am already working on the first bug, in Create UI, in #16700.

Try to fix the second bug in this ticket. Thanks!

ArwenQin · 2024-09-12T21:13:53Z

The Edit UI bug mentioned above is fixed in this PR: 16500 - Fixed Restoration People Section Bug business-edit-ui#588
I found another 2 bugs, which I believe are with Legal API issue:

For Limited Restoration Extension/Conversion, if we replace the original person/business with a new business, the process fails

File and Pay process fails:

If we remove the original person/business and replace it with a new person - processed successfully.
However, after it, when we open a new extension/conversion file, the new added person is not updated, and the removed old person is still there.

@severinbeauvais

severinbeauvais · 2024-09-12T21:38:06Z

@Mihai-QuickSilverDev ~~Please look at Arwen's findings above regarding the replacement of the applicant in a Limited Restoration Extension (which was pre-populated from the limited restoration filing). Is it allowed?~~ wait, I'm still trying to understand what's going on; no need to answer this

deleted obsolete comment

severinbeauvais · 2024-09-12T21:50:31Z

SB's analysis

The first bug is a schema validation error. Arwen, you'll have to compare the filing JSON with the appropriate schemas to see what's invalid.

The second bug is a back end error. Arwen will create a new bug ticket for it.

ArwenQin · 2024-09-12T22:24:31Z

New bug ticket created for the back end error (remove and add person):
https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/23277

ArwenQin · 2024-09-17T17:29:50Z

Fixed the bug that Person section cannot "undo" after changes (16500 - Fixed Restoration People Section Bug business-edit-ui#588)
Fixed the bug that removed and added person are not updated (16500 - Fixed Restoration People Section Bug business-edit-ui#588)
This issue was previously in ticket
https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/23277
We can now verify this ticket
Fixed the bug when the person is a business/corporation, the file and pay fails (fixed the party schema) (16500 - Fixed Restoration People Section Bug business-edit-ui#588)
For the schema, I found the taxId and identifier are not in the Person schema, while we have it in the filing JSON

And the middleName (UI) doesn't match middleInitial (schema), but there is a note:

Not sure whether we should update the schema?

@severinbeauvais

severinbeauvais · 2024-09-17T20:02:21Z

For the schema, I found the taxId and identifier are not in the Person schema, while we have it in the filing JSON

@vysakh-menon-aot , do you think we should add optional taxId and identified in the schema?

And the middleName (UI) doesn't match middleInitial (schema), but there is a note:

@vysakh-menon-aot , the UI saves "middleName" instead of "middleInitial". Does the BE convert it? (I think if we convert it in the UI then a lot of other UI code will need to be updated to convert it back and forth on draft resume.)

ArwenQin · 2024-09-17T21:47:05Z

@vysakh-menon-aot
CC: @severinbeauvais
Hi Vysakh, could you please try to reproduce this bug:
file a correction to an IA, try to change the directors (add one, edit, or remove one). After file the correction, will you see the incorporator showing in the director's section?

Please see the unnamed incorporator. It seems impossible, the incorporator shouldn't show in the director's page. This bug may be hard to reproduce.
And I was able to delete the incorporator from that section for BC1218838. Could you please check in the database?
Thanks.

vysakh-menon-aot · 2024-09-17T21:47:12Z

For the schema, I found the taxId and identifier are not in the Person schema, while we have it in the filing JSON

@vysakh-menon-aot , do you think we should add optional taxId and identifier in the schema?

there is no logic around taxid in party (can keep it in the json without adding to schema). identifier is already part of schema (https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/party.json#L34).

And the middleName (UI) doesn't match middleInitial (schema), but there is a note:

@vysakh-menon-aot , the UI saves "middleName" instead of "middleInitial". Does the BE convert it? (I think if we convert it in the UI then a lot of other UI code will need to be updated to convert it back and forth on draft resume.)

Currently we support both middleName and middleInitial in party object (event though only middleInitial in schema) while creating/updating parties (entity-filer), I don't remember if we have a ticket to change this. If we are changing it to middleInitial we need to verifiy if its showing in all scenarios

vysakh-menon-aot · 2024-09-17T21:57:44Z

@vysakh-menon-aot CC: @severinbeauvais Hi Vysakh, could you please try to reproduce this bug: file a correction to an IA, try to change the directors (add one, edit, or remove one). After file the correction, will you see the incorporator showing in the director's section? Please see the unnamed incorporator. It seems impossible, the incorporator shouldn't show in the director's page. This bug may be hard to reproduce. And I was able to delete the incorporator from that section for BC1218838. Could you please check in the database? Thanks.

I cannot reproduce

ArwenQin · 2024-09-17T22:00:35Z

@vysakh-menon-aot

I cannot reproduce

Thanks a lot!
We are wondering it might be that someone did something weird in the Dev db. Do you think if changing something in the db could lead to this bug, or whether it has to be a logic bug.

vysakh-menon-aot · 2024-09-17T22:04:31Z

If its a draft filing (which is in json) backend will not modify the data

ArwenQin · 2024-09-17T22:11:27Z

#23343 created for the bug that business name didn't show in the Restoration application/extension output

ArwenQin · 2024-09-18T18:37:31Z

Test note:
Fixed 3 bugs in this ticket:

Conversion to Full Restoration or Limited Restoration Extension page, when we edited the Applicant Person's information, click "Save and Resume", then go back - the "Undo" function doesn't work anymore
Fixed this bug by removing the re-assign officer ID.
Fixed the bug that removed and added person are not updated, previously in ticket
https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/23277
(verified ticket 23277)
Fixed the bug when the person is a business/corporation, the file and pay fails (fixed the party schema)

severinbeauvais · 2024-09-18T18:39:36Z

I cannot reproduce

@vysakh-menon-aot Can you think of any db or logic situation that could have caused this? Both Arwen and I saw the Incorporator (albeit with no name) in the director list in a correction.

severinbeauvais · 2024-09-18T22:02:45Z

As for the incorporator displaying in the list of directors, see ticket #23395.

severinbeauvais added bug Something isn't working ENTITY Business Team labels May 25, 2023

severinbeauvais mentioned this issue May 25, 2023

Edit UI, Create UI: fix slow builds #16204

Closed

3 tasks

This was referenced May 25, 2023

Lear API - Validate mandatory dates for Registrar Approval #16155

Closed

Edit UI - Conversion to Full Restoration Application Output showing the wrong Approval Type. #16081

Closed

jdyck-fw added Priority2 Priority1 and removed Priority2 Priority1 labels Jun 14, 2023

davemck513 added Priority2 and removed Priority1 labels Jul 17, 2023

NaveenHebbale added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Feb 28, 2024

vikas-gov mentioned this issue Aug 30, 2024

Sprint 22.6 Objectives #23038

Closed

15 tasks

severinbeauvais self-assigned this Sep 11, 2024

severinbeauvais removed their assignment Sep 11, 2024

ArwenQin self-assigned this Sep 11, 2024

ArwenQin mentioned this issue Sep 12, 2024

16500 - Fixed Restoration People Section Bug bcgov/business-edit-ui#588

Merged

ArwenQin mentioned this issue Sep 17, 2024

Edit UI: Verify Restoration Extension/Conversion Error - Remove Person #23277

Closed

vikas-gov mentioned this issue Sep 19, 2024

Sprint 22.7 Objectives #23399

Closed

12 tasks

OlgaPotiagalova closed this as completed Sep 27, 2024

vikas-gov mentioned this issue Oct 2, 2024

Sprint 23.1 Objectives #23612

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit UI: full restoration bugs (date fields, approval type) #16500

Edit UI: full restoration bugs (date fields, approval type) #16500

severinbeauvais commented May 25, 2023 •

edited by ArwenQin

Loading

severinbeauvais commented May 25, 2023

severinbeauvais commented Sep 11, 2024 •

edited

Loading

ArwenQin commented Sep 11, 2024

ArwenQin commented Sep 11, 2024

severinbeauvais commented Sep 11, 2024

severinbeauvais commented Sep 11, 2024

Mihai-QuickSilverDev commented Sep 11, 2024 •

edited by severinbeauvais

Loading

severinbeauvais commented Sep 11, 2024

ArwenQin commented Sep 11, 2024 •

edited by severinbeauvais

Loading

ArwenQin commented Sep 11, 2024 •

edited

Loading

severinbeauvais commented Sep 11, 2024 •

edited

Loading

severinbeauvais commented Sep 12, 2024

ArwenQin commented Sep 12, 2024

severinbeauvais commented Sep 12, 2024 •

edited

Loading

severinbeauvais commented Sep 12, 2024 •

edited

Loading

ArwenQin commented Sep 12, 2024

ArwenQin commented Sep 17, 2024

severinbeauvais commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

vysakh-menon-aot commented Sep 17, 2024 •

edited

Loading

vysakh-menon-aot commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

vysakh-menon-aot commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

ArwenQin commented Sep 18, 2024

severinbeauvais commented Sep 18, 2024

severinbeauvais commented Sep 18, 2024

Edit UI: full restoration bugs (date fields, approval type) #16500

Edit UI: full restoration bugs (date fields, approval type) #16500

Comments

severinbeauvais commented May 25, 2023 • edited by ArwenQin Loading

severinbeauvais commented May 25, 2023

FE Http Request Body

severinbeauvais commented Sep 11, 2024 • edited Loading

ArwenQin commented Sep 11, 2024

ArwenQin commented Sep 11, 2024

severinbeauvais commented Sep 11, 2024

severinbeauvais commented Sep 11, 2024

Mihai-QuickSilverDev commented Sep 11, 2024 • edited by severinbeauvais Loading

severinbeauvais commented Sep 11, 2024

ArwenQin commented Sep 11, 2024 • edited by severinbeauvais Loading

ArwenQin commented Sep 11, 2024 • edited Loading

severinbeauvais commented Sep 11, 2024 • edited Loading

severinbeauvais commented Sep 12, 2024

ArwenQin commented Sep 12, 2024

severinbeauvais commented Sep 12, 2024 • edited Loading

severinbeauvais commented Sep 12, 2024 • edited Loading

SB's analysis

ArwenQin commented Sep 12, 2024

ArwenQin commented Sep 17, 2024

severinbeauvais commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

vysakh-menon-aot commented Sep 17, 2024 • edited Loading

vysakh-menon-aot commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

vysakh-menon-aot commented Sep 17, 2024

ArwenQin commented Sep 17, 2024

ArwenQin commented Sep 18, 2024

severinbeauvais commented Sep 18, 2024

severinbeauvais commented Sep 18, 2024

severinbeauvais commented May 25, 2023 •

edited by ArwenQin

Loading

severinbeauvais commented Sep 11, 2024 •

edited

Loading

Mihai-QuickSilverDev commented Sep 11, 2024 •

edited by severinbeauvais

Loading

ArwenQin commented Sep 11, 2024 •

edited by severinbeauvais

Loading

ArwenQin commented Sep 11, 2024 •

edited

Loading

severinbeauvais commented Sep 11, 2024 •

edited

Loading

severinbeauvais commented Sep 12, 2024 •

edited

Loading

severinbeauvais commented Sep 12, 2024 •

edited

Loading

vysakh-menon-aot commented Sep 17, 2024 •

edited

Loading