16204 Fixed slow build + unit tests #500
Conversation
- restricted vue version to fix slow/frozen build process - fixed "rules" type bugs - updated unit tests
| @@ -52,7 +52,7 @@ | |||
| "tiptap-vuetify": "^2.24.0", | |||
| "uuid": "^9.0.0", | |||
| "v-sanitize": "^0.0.11", | |||
| "vue": "^2.7.14", | |||
| "vue": "2.7.10", | |||
There was a problem hiding this comment.
Something happened in 2.7.11 that caused the build to take much longer and sometimes hang. Supposedly it was fixed... but it still happens in 2.7.14.
Note the lack of ^ so that npm doesn't automatically take the latest "2.x.x" version.
There was a problem hiding this comment.
should we check other UIs?
There was a problem hiding this comment.
Yep - see bcgov/business-create-ui#550.
| @@ -95,7 +95,7 @@ | |||
| "vue-cli-plugin-vuetify": "^2.5.8", | |||
| "vue-plugin-helper-decorator": "^0.0.12", | |||
| "vue-property-decorator": "^9.1.2", | |||
| "vue-template-compiler": "2.7.14", | |||
| "vue-template-compiler": "2.7.10", | |||
There was a problem hiding this comment.
Must match vue version above.
| @@ -37,7 +37,7 @@ | |||
| label="Enter the NR Number" | |||
| hint="Example: NR 1234567" | |||
| persistent-hint | |||
| :rules="done && nrNumRules" | |||
| :rules="done ? nrNumRules : []" | |||
There was a problem hiding this comment.
Fix for error "expected array but got type boolean".
| }, | ||
| vuetify | ||
| }) | ||
| } |
There was a problem hiding this comment.
There was some random error in here so I cleaned it up.
| // Store required for component, although not read or modified in unit test. | ||
| setActivePinia(createPinia()) | ||
|
|
||
| describe('SigningParty', () => { | ||
| let wrapper | ||
|
|
||
| beforeEach(() => { | ||
| wrapper = mount(SigningParty) | ||
| wrapper = mount(SigningParty, { vuetify }) |
There was a problem hiding this comment.
Fix for test error "did you register component v-row correctly?"
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 86.96% 85.65% -1.32%
==========================================
Files 195 202 +7
Lines 3645 3757 +112
Branches 444 468 +24
==========================================
+ Hits 3170 3218 +48
- Misses 462 524 +62
- Partials 13 15 +2
|
Issue #: bcgov/entity#16204
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).