Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1232 add flyway script to add a new client role #1237

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

MCatherine1994
Copy link
Contributor

@MCatherine1994 MCatherine1994 commented Mar 13, 2024

refs: #1232

  • Remove the old client roles (USER_READ, USER_WRITE) we created when onboarding them to FAM, we just created those two roles for them to play around, they are not in use
  • Add a new role "CLIENT_EDITOR"

Note: this pr is for a hotfix release followed the hotfix release strategy, so the fix branch fix/1232-add-client-role will be merged to a hotfix base branch (based on last release v1.12.0, and it has to be named "hotfix") to trigger release please management for hotfix release. The pr title starts with "fix", so the hotfix release tag will only bump a patch version, become v1.12.1, and won't conflict with our regular release v.1.13.0. Once we deploy the hotfix release in production, will create a new pr to merge the hotfix branch to main.

@MCatherine1994
Copy link
Contributor Author

Discussed with Olga, for this hotfix release, will only focus on creating the new role, have a new ticket for updating the application name #1236, logout url will be done later in ticket #1233.

For new FOM role, and SPAR role, we feel those are not that urgent and can wait 1-2 sprints, so this hotfix will just be the new role for Client

Copy link
Collaborator

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MCatherine1994 MCatherine1994 merged commit e744380 into hotfix Mar 14, 2024
10 checks passed
@MCatherine1994 MCatherine1994 deleted the fix/1232-add-client-role branch March 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants