Skip to content

Commit

Permalink
Fix bevy_window failing with serialize feature (#14298)
Browse files Browse the repository at this point in the history
# Objective

- [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy) found an
issue where `bevy_window` would fail to build when its `serialize`
feature is enabled.
- See
[here](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/9924187577/job/27415224405)
for the specific log.

## Solution

- Turns out it was failing because the `bevy_ecs/serialize` feature was
not enabled. This error can be fixed by adding the flag as a dependency.

## Testing

```bash
cargo check -p bevy_window -F serialize
# Or if you're very cool...
flag-frenzy --manifest-path path/to/bevy/Cargo.toml --config config -p bevy_window
```
  • Loading branch information
BD103 authored and mockersf committed Aug 2, 2024
1 parent 728c5b9 commit 70a0c21
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/bevy_window/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ keywords = ["bevy"]

[features]
default = []
serialize = ["serde", "smol_str/serde"]
serialize = ["serde", "smol_str/serde", "bevy_ecs/serialize"]

[dependencies]
# bevy
Expand Down

0 comments on commit 70a0c21

Please sign in to comment.