-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bevy_window
failing with serialize
feature
#14298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only read the PR description and reviewed the code diff. Have not investigated whether this is correct or the potential implications.
@alice-i-cecile should the bug fix be backported to 0.14.1? If so, I should probably split this into two different PRs. |
Yes, please split this for backporting. |
This reverts commit 35fbbcc.
# Objective - Extracted from #14298. - `bevy_window` has an empty `default` feature that does not enable anything, which is equivalent to not having any default features. ## Solution - Remove it :) - This is technically a breaking change, but specifying `features = ["default"]` manually in `Cargo.toml` is highly discouraged, so the impact is low. --- ## Migration Guide `bevy_window` had an empty default feature flag that did not do anything, so it was removed. You may have to remove any references to it if you specified it manually. ```toml # 0.14 [dependencies] bevy_window = { version = "0.14", default-features = false, features = ["default"] } # 0.15 [dependencies] bevy_window = { version = "0.15", default-features = false } ```
# Objective - [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy) found an issue where `bevy_window` would fail to build when its `serialize` feature is enabled. - See [here](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/9924187577/job/27415224405) for the specific log. ## Solution - Turns out it was failing because the `bevy_ecs/serialize` feature was not enabled. This error can be fixed by adding the flag as a dependency. ## Testing ```bash cargo check -p bevy_window -F serialize # Or if you're very cool... flag-frenzy --manifest-path path/to/bevy/Cargo.toml --config config -p bevy_window ```
Objective
flag-frenzy
found an issue wherebevy_window
would fail to build when itsserialize
feature is enabled.Solution
bevy_ecs/serialize
feature was not enabled. This error can be fixed by adding the flag as a dependency.Testing
cargo check -p bevy_window -F serialize # Or if you're very cool... flag-frenzy --manifest-path path/to/bevy/Cargo.toml --config config -p bevy_window