Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation's reflection trait bounds can be simplified #15392

Closed
alice-i-cecile opened this issue Sep 23, 2024 · 0 comments · Fixed by #15495
Closed

Animation's reflection trait bounds can be simplified #15392

alice-i-cecile opened this issue Sep 23, 2024 · 0 comments · Fixed by #15495
Labels
A-Animation Make things move and change over time A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member

Note: This should now be replaceable by Reflectable (on main, see #5772).

Originally posted by @MrGVSV in #15282 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Animation Make things move and change over time A-Reflection Runtime information about types S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon labels Sep 23, 2024
@chompaa chompaa mentioned this issue Sep 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 28, 2024
@chompaa
Simplify AnimatableProperty::Property trait bounds (#15495)
05d2013 
# Objective

- Fixes #15392.

## Solution

- Use `Reflectable` in place of `GetTypeRegistration + Reflect +
TypePath + Typed`.
robtfm pushed a commit to robtfm/bevy that referenced this issue Oct 4, 2024
@chompaa @robtfm
Simplify AnimatableProperty::Property trait bounds (bevyengine#15495)
56d01cf 
# Objective

- Fixes bevyengine#15392.

## Solution

- Use `Reflectable` in place of `GetTypeRegistration + Reflect +
TypePath + Typed`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify AnimatableProperty::Property trait bounds chompaa/bevy
1 participant
@alice-i-cecile