Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AnimatableProperty::Property trait bounds #15495

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Simplify AnimatableProperty::Property trait bounds #15495

merged 1 commit into from
Sep 28, 2024

Conversation

chompaa
Copy link
Member

@chompaa chompaa commented Sep 28, 2024

Objective

Solution

  • Use Reflectable in place of GetTypeRegistration + Reflect + TypePath + Typed.

@chompaa chompaa added C-Code-Quality A section of code that is hard to understand or change A-Animation Make things move and change over time A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Trivial Nice and easy! A great choice to get started with Bevy labels Sep 28, 2024
alice-i-cecile
alice-i-cecile approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, merging!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 28, 2024
Merged via the queue into bevyengine:main with commit 05d2013 Sep 28, 2024
33 checks passed
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@chompaa @robtfm
Simplify AnimatableProperty::Property trait bounds (bevyengine#15495)
56d01cf 
# Objective

- Fixes bevyengine#15392.

## Solution

- Use `Reflectable` in place of `GetTypeRegistration + Reflect +
TypePath + Typed`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animation's reflection trait bounds can be simplified
2 participants
@chompaa @alice-i-cecile