Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Events<T> into bevy_ecs #1809

Closed
TheRawMeatball opened this issue Apr 3, 2021 · 0 comments
Closed

Move Events<T> into bevy_ecs #1809

TheRawMeatball opened this issue Apr 3, 2021 · 0 comments
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@TheRawMeatball
Copy link
Member

Events are a general purpose message-passing primitive that would be useful to people who use bevy_ecs standalone, so IMO it makes sense to pull it into bevy_ecs

What solution would you like?

Move Events into bevy_ecs

What alternative(s) have you considered?

Do nothing

Additional context

Here's the conversation on discord that led this issue: https://discord.com/channels/691052431525675048/730525730601041940/827954577672372224
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy labels Apr 3, 2021
@YohDeadfall YohDeadfall mentioned this issue Apr 5, 2021
Closed
@bors bors bot closed this as completed in 04a37f7 Apr 13, 2021
jihiggins pushed a commit to jihiggins/bevy that referenced this issue Apr 18, 2021
@YohDeadfall @jihiggins
Moved events to ECS (bevyengine#1823)
d252ec6 
Fixes bevyengine#1809. It makes it also possible to use `derive` for `SystemParam` inside ECS and avoid manual implementation. An alternative solution to macro changes is to use `use crate as bevy_ecs;` in `event.rs`.
ostwilkens pushed a commit to ostwilkens/bevy that referenced this issue Jul 27, 2021
@YohDeadfall @ostwilkens
Moved events to ECS (bevyengine#1823)
11ade33 
Fixes bevyengine#1809. It makes it also possible to use `derive` for `SystemParam` inside ECS and avoid manual implementation. An alternative solution to macro changes is to use `use crate as bevy_ecs;` in `event.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Moved events to ECS YohDeadfall/bevy
2 participants
@alice-i-cecile @TheRawMeatball