Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Moved events to ECS #1823

Closed
wants to merge 5 commits into from

Conversation

YohDeadfall
Copy link
Member

@YohDeadfall YohDeadfall commented Apr 5, 2021

Fixes #1809. It makes it also possible to use derive for SystemParam inside ECS and avoid manual implementation. An alternative solution to macro changes is to use use crate as bevy_ecs; in event.rs.

@TheRawMeatball TheRawMeatball added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 11, 2021
@cart
Copy link
Member

cart commented Apr 13, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 13, 2021
Fixes #1809. It makes it also possible to use `derive` for `SystemParam` inside ECS and avoid manual implementation. An alternative solution to macro changes is to use `use crate as bevy_ecs;` in `event.rs`.
@bors bors bot changed the title Moved events to ECS [Merged by Bors] - Moved events to ECS Apr 13, 2021
@bors bors bot closed this Apr 13, 2021
@YohDeadfall YohDeadfall deleted the ecs-events branch April 13, 2021 20:57
jihiggins pushed a commit to jihiggins/bevy that referenced this pull request Apr 18, 2021
Fixes bevyengine#1809. It makes it also possible to use `derive` for `SystemParam` inside ECS and avoid manual implementation. An alternative solution to macro changes is to use `use crate as bevy_ecs;` in `event.rs`.
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
Fixes bevyengine#1809. It makes it also possible to use `derive` for `SystemParam` inside ECS and avoid manual implementation. An alternative solution to macro changes is to use `use crate as bevy_ecs;` in `event.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Events<T> into bevy_ecs
4 participants