Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Rename or hide bevy_ui::ui_node::Direction #6286

Closed
lewiszlw opened this issue Oct 18, 2022 · 3 comments · Fixed by #14793
Closed

[Minor] Rename or hide bevy_ui::ui_node::Direction #6286

lewiszlw opened this issue Oct 18, 2022 · 3 comments · Fixed by #14793
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Enhancement A new feature C-Usability A simple quality-of-life change that makes Bevy easier to use

Comments

@lewiszlw
Copy link
Member

I'm a new bie to game dev and writing my first 2d game with bevy.
Direction is basic component I think when developing games, but it conflicts with bevy_ui::ui_node::Direction when I want to import it, so I have to import it with mod name. I check the desc on bevy_ui::ui_node::Direction, this enum is for text direction, so is this reasonable to rename bevy_ui::ui_node::Direction to bevy_ui::ui_node::TextDirection, or may hide it in bevy::prelude::* if useless for game developers?
@lewiszlw lewiszlw added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Oct 18, 2022
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A simple quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Oct 18, 2022
@alice-i-cecile
Copy link
Member

Agreed. This should be fixed as we split the Style component.

@lewiszlw
Copy link
Member Author

Nice, hope to see this improvement in next version. Closing.

@alice-i-cecile
Copy link
Member

#5513 isn't merged yet; I'm going to reopen this but mark that it'll be fixed by that PR :)

@alice-i-cecile alice-i-cecile mentioned this issue Oct 18, 2022
Closed
@rparrett rparrett mentioned this issue Aug 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 19, 2024
@rparrett
Remove useless Direction field (#14793)
618cf7f 
# Objective

Delete some code that isn't actually doing anything. This was actually
discovered way back in this obsolete PR: #5513.

Also Fixes #6286

## Solution

Delete it

## Alternatives

Make `Direction` do things. But it's not totally clear to me if it's
possible to override cosmic-text's unicode bidi stuff.

## Migration Guide

`Style` no longer has a `direction` field, and `Direction` has been
deleted. They didn't do anything, so you can delete any references to
them as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Enhancement A new feature C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
2 participants
@alice-i-cecile @lewiszlw