Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless Direction field #14793

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Remove useless Direction field #14793

merged 1 commit into from
Aug 19, 2024

Conversation

rparrett
Copy link
Contributor

Objective

Delete some code that isn't actually doing anything. This was actually discovered way back in this obsolete PR: #5513.

Also Fixes #6286

Solution

Delete it

Alternatives

Make Direction do things. But it's not totally clear to me if it's possible to override cosmic-text's unicode bidi stuff.

Migration Guide

Style no longer has a direction field, and Direction has been deleted. They didn't do anything, so you can delete any references to them as well.

@IQuick143 IQuick143 added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 17, 2024
alice-i-cecile
alice-i-cecile approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't leave footguns lying about. We can add this back in later.

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Aug 17, 2024
@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 17, 2024
@TotalKrill TotalKrill self-requested a review August 19, 2024 19:22
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 19, 2024
Merged via the queue into bevyengine:main with commit 618cf7f Aug 19, 2024
33 checks passed
@doup doup mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BD103 BD103 BD103 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@TotalKrill TotalKrill TotalKrill approved these changes

@nicoburns nicoburns Awaiting requested review from nicoburns

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

[Minor] Rename or hide bevy_ui::ui_node::Direction
5 participants
@rparrett @TotalKrill @alice-i-cecile @BD103 @IQuick143