Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy CI check-bans failing found 2 duplicate entries for crate 'windows' #7654

Closed
LiamGallagher737 opened this issue Feb 13, 2023 · 1 comment
Closed

Bevy CI check-bans failing found 2 duplicate entries for crate 'windows' #7654

LiamGallagher737 opened this issue Feb 13, 2023 · 1 comment
Labels
A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@LiamGallagher737
Copy link
Contributor

LiamGallagher737 commented Feb 13, 2023 •
edited
Loading

Any PRs that edit the Cargo.toml will fail the check-bans check. Two examples of this are #7652 and #7648.

error[duplicate]: found 2 duplicate entries for crate 'windows'
    ┌─ /home/runner/work/bevy/bevy/Cargo.lock:322:1
    │  
322 │ ╭ windows 0.43.0 registry+https://github.com/rust-lang/crates.io-index
323 │ │ windows 0.44.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰────────────────────────────────────────────────────────────────────^ lock entries
    │

wgpu-hal updated 3 days ago, which bevy-render has a dependency on and now has a different version of windows

Here is the related discussion
https://discord.com/channels/691052431525675048/1074588631622238289
@LiamGallagher737 LiamGallagher737 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 13, 2023
@aevyrie aevyrie mentioned this issue Feb 14, 2023
Closed
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on and removed C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 14, 2023
@LiamGallagher737
Copy link
Contributor Author

These are the duplicates of the windows crate

windows v0.43.0
└── gilrs-core v0.5.2 (*)

windows v0.44.0
└── gpu-allocator v0.22.0 (*)

windows-sys v0.42.0
└── notify v5.1.0
    └── bevy_asset v0.9.0 (E:\Projects\bevy\crates\bevy_asset) (*)

@aevyrie aevyrie mentioned this issue Feb 15, 2023
Merged
@DanielHZhang DanielHZhang mentioned this issue Feb 16, 2023
Closed
@bors bors bot closed this as completed in 95c8d88 Feb 16, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this issue Feb 16, 2023
@DanielHZhang @myreprise1
Fix failing CI check-bans due to duplicate windows dependency (be…
183d9d5 
…vyengine#7699)

# Objective

Fixes bevyengine#7654 

## Solution

Add `windows v0.43` to the list of skipped dependencies checked by CI (until `gilrs` publishes a new release with `windows v0.44`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix failing CI check-bans due to duplicate windows dependency DanielHZhang/bevy
2 participants
@alice-i-cecile @LiamGallagher737