Keep async-channel version same

[lewiszlw]

Objective

When I update bevy to latest bevy main branch for my game, async-channel version conflicts.

error: failed to select a version for `async-channel`.
    ... required by package `bevy_render v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_render` of package `bevy_core_pipeline v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_core_pipeline` of package `bevy_gltf v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_gltf` of package `bevy_internal v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_internal` of package `bevy v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy` of package `tetris v0.1.0 (/Users/lewis/Github/tetris)`
versions that meet the requirements `^1.8` are: 1.8.0

all possible versions conflict with previously selected packages.

  previously selected package `async-channel v1.7.1`
    ... which satisfies dependency `async-channel = "^1.4"` (locked to 1.7.1) of package `bevy_ecs v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_ecs` of package `bevy_animation v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_animation` of package `bevy_gltf v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_gltf` of package `bevy_internal v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy_internal` of package `bevy v0.9.0 (https://github.com/bevyengine/bevy?rev=f7fbfaf9c72035e98c6b6cec0c7d26ff9f5b1c82#f7fbfaf9)`
    ... which satisfies git dependency `bevy` of package `tetris v0.1.0 (/Users/lewis/Github/tetris)`

failed to select a version for `async-channel` which could resolve this conflict

Solution

• Keep async-channel version same

[lewiszlw]

CI dependencies check-bans failed due to error[duplicate]: found 2 duplicate entries for crate 'windows' (which depended by gilrs and wgpu-hal), How can I resolve?

[alice-i-cecile]

Weird that it was causing you such issues. Can you reproduce after a cargo clean?

[mockersf]

That change probably wouldn't fix your issue. You had an existing lock file with the 1.7 version, and updating to Bevy main the minimum version needed was 1.8 (from bevy_render) which wasn't compatible with your lock file.

In theory this PR is a breaking change as it would mean people using just bevy_ecs will have to update async-channel, while it would still work with the 1.4

[alice-i-cecile]

In theory this PR is a breaking change as it would mean people using just bevy_ecs will have to update async-channel, while it would still work with the 1.4

Is it a breaking change to update a minor version of a dependency? That doesn't seem quite right to me.

[mockersf]

If someone specified a fixed version of the dependency, then updating bevy_ecs requiring the newest dependency would break compilation 🤷

[lewiszlw]

Weird that it was causing you such issues. Can you reproduce after a cargo clean?

Yeah, I need cargo clean. Do we still need to bump async-channel crate version, if not, I'll close this pr. @alice-i-cecile

[alice-i-cecile]

No strong feelings here. I'll close it out for now.