Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe wrong schedule for update_previous_view_projections #8630

Closed
JMS55 opened this issue May 17, 2023 · 0 comments · Fixed by #9024
Closed

Maybe wrong schedule for update_previous_view_projections #8630

JMS55 opened this issue May 17, 2023 · 0 comments · Fixed by #9024
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone
0.11

Comments

@JMS55
Copy link
Contributor

JMS55 commented May 17, 2023

I think this should maybe be PreUpdate? I can't remember why I went with Update, or if that was intentional or not.

https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/prepass/mod.rs#L145
@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels May 17, 2023
@JMS55 JMS55 added this to the 0.11 milestone May 17, 2023
@geieredgar geieredgar mentioned this issue Jul 2, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 5, 2023
@geieredgar
Run update_previous_view_projections in PreUpdate schedule (#9024)
e03dd4d 
# Objective

- Fixes #8630.

## Solution

Since a camera's view and projection matrices are modified during
`PostUpdate` in `camera_system` and `propagate_transforms`, it is fine
to move `update_previous_view_projections` from `Update` to `PreUpdate`.
Doing so adds consistence with `update_mesh_previous_global_transforms`
and allows systems in `Update` to use `PreviousViewProjection` correctly
without explicit ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Run update_previous_view_projections in PreUpdate schedule geieredgar/bevy
1 participant
@JMS55