Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Arc3D for Gizmos #11540
Implement Arc3D for Gizmos #11540
Changes from 5 commits
6641e67
5605b21
219a44d
c153046
d4e19e3
221a282
bd1b114
2e064f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit nervous about using "behavior is undefined" here (and above): it's not UB in the compiler sense and we may confuse readers. Maybe "graphical glitches may occur"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!
I just tested these cases (after all we're also part scientists, right? :D). It seems like nothing happens at all. We should probably communicate this to the user.
Do you think an early return might make sense? I'm not really sure. On the one hand we could save some compute in the case that we wouldn't draw anything anyways. On the other hand this is an edge case and adding two checks for every non-edge case might be needless overhead.
I think I'm just going for changing the comment for now, but please let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think let's just change the comment and leave the behavior for now. I'm really not concerned about the performance in pathological cases and if it doesn't crash I'm quite happy with it as is.