-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made bevy_color
a dependency of bevy_render
#12105
Merged
alice-i-cecile
merged 4 commits into
bevyengine:main
from
bushrat011899:InvertRenderColorDependency
Feb 25, 2024
Merged
Made bevy_color
a dependency of bevy_render
#12105
alice-i-cecile
merged 4 commits into
bevyengine:main
from
bushrat011899:InvertRenderColorDependency
Feb 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inverts the dependency graph to more appropriately reflect how `bevy_render` and `bevy_color` relate to each other.
bushrat011899
added
A-Rendering
Drawing game state to the screen
C-Code-Quality
A section of code that is hard to understand or change
labels
Feb 25, 2024
afonsolage
suggested changes
Feb 25, 2024
afonsolage
approved these changes
Feb 25, 2024
alice-i-cecile
added
the
C-Breaking-Change
A breaking change to Bevy's public API that needs to be noted in a migration guide
label
Feb 25, 2024
alice-i-cecile
approved these changes
Feb 25, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Feb 25, 2024
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective - Fixes bevyengine#12068 ## Solution - Split `bevy_render::color::colorspace` across the various space implementations in `bevy_color` as appropriate. - Moved `From` implementations involving `bevy_render::color::LegacyColor` into `bevy_render::color` ## Migration Guide ### `bevy_render::color::colorspace::SrgbColorSpace::<f32>::linear_to_nonlinear_srgb` Use `bevy_color::color::gamma_function_inverse` ### `bevy_render::color::colorspace::SrgbColorSpace::<f32>::nonlinear_to_linear_srgb` Use `bevy_color::color::gamma_function` ### `bevy_render::color::colorspace::SrgbColorSpace::<u8>::linear_to_nonlinear_srgb` Modify the `u8` value to instead be an `f32` (`|x| x as f32 / 255.`), use `bevy_color::color::gamma_function_inverse`, and back again. ### `bevy_render::color::colorspace::SrgbColorSpace::<u8>::nonlinear_to_linear_srgb` Modify the `u8` value to instead be an `f32` (`|x| x as f32 / 255.`), use `bevy_color::color::gamma_function`, and back again. ### `bevy_render::color::colorspace::HslRepresentation::hsl_to_nonlinear_srgb` Use `Hsla`'s implementation of `Into<Srgba>` ### `bevy_render::color::colorspace::HslRepresentation::nonlinear_srgb_to_hsl` Use `Srgba`'s implementation of `Into<Hsla>` ### `bevy_render::color::colorspace::LchRepresentation::lch_to_nonlinear_srgb` Use `Lcha`'s implementation of `Into<Srgba>` ### `bevy_render::color::colorspace::LchRepresentation::nonlinear_srgb_to_lch` Use `Srgba`'s implementation of `Into<Lcha>`
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective - Fixes bevyengine#12068 ## Solution - Split `bevy_render::color::colorspace` across the various space implementations in `bevy_color` as appropriate. - Moved `From` implementations involving `bevy_render::color::LegacyColor` into `bevy_render::color` ## Migration Guide ### `bevy_render::color::colorspace::SrgbColorSpace::<f32>::linear_to_nonlinear_srgb` Use `bevy_color::color::gamma_function_inverse` ### `bevy_render::color::colorspace::SrgbColorSpace::<f32>::nonlinear_to_linear_srgb` Use `bevy_color::color::gamma_function` ### `bevy_render::color::colorspace::SrgbColorSpace::<u8>::linear_to_nonlinear_srgb` Modify the `u8` value to instead be an `f32` (`|x| x as f32 / 255.`), use `bevy_color::color::gamma_function_inverse`, and back again. ### `bevy_render::color::colorspace::SrgbColorSpace::<u8>::nonlinear_to_linear_srgb` Modify the `u8` value to instead be an `f32` (`|x| x as f32 / 255.`), use `bevy_color::color::gamma_function`, and back again. ### `bevy_render::color::colorspace::HslRepresentation::hsl_to_nonlinear_srgb` Use `Hsla`'s implementation of `Into<Srgba>` ### `bevy_render::color::colorspace::HslRepresentation::nonlinear_srgb_to_hsl` Use `Srgba`'s implementation of `Into<Hsla>` ### `bevy_render::color::colorspace::LchRepresentation::lch_to_nonlinear_srgb` Use `Lcha`'s implementation of `Into<Srgba>` ### `bevy_render::color::colorspace::LchRepresentation::nonlinear_srgb_to_lch` Use `Srgba`'s implementation of `Into<Lcha>`
BD103
added
A-Color
Color spaces and color math
A-Rendering
Drawing game state to the screen
and removed
A-Rendering
Drawing game state to the screen
labels
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Color
Color spaces and color math
A-Rendering
Drawing game state to the screen
C-Breaking-Change
A breaking change to Bevy's public API that needs to be noted in a migration guide
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
bevy_render::color::colorspace
across the various space implementations inbevy_color
as appropriate.From
implementations involvingbevy_render::color::LegacyColor
intobevy_render::color
Migration Guide
bevy_render::color::colorspace::SrgbColorSpace::<f32>::linear_to_nonlinear_srgb
Use
bevy_color::color::gamma_function_inverse
bevy_render::color::colorspace::SrgbColorSpace::<f32>::nonlinear_to_linear_srgb
Use
bevy_color::color::gamma_function
bevy_render::color::colorspace::SrgbColorSpace::<u8>::linear_to_nonlinear_srgb
Modify the
u8
value to instead be anf32
(|x| x as f32 / 255.
), usebevy_color::color::gamma_function_inverse
, and back again.bevy_render::color::colorspace::SrgbColorSpace::<u8>::nonlinear_to_linear_srgb
Modify the
u8
value to instead be anf32
(|x| x as f32 / 255.
), usebevy_color::color::gamma_function
, and back again.bevy_render::color::colorspace::HslRepresentation::hsl_to_nonlinear_srgb
Use
Hsla
's implementation ofInto<Srgba>
bevy_render::color::colorspace::HslRepresentation::nonlinear_srgb_to_hsl
Use
Srgba
's implementation ofInto<Hsla>
bevy_render::color::colorspace::LchRepresentation::lch_to_nonlinear_srgb
Use
Lcha
's implementation ofInto<Srgba>
bevy_render::color::colorspace::LchRepresentation::nonlinear_srgb_to_lch
Use
Srgba
's implementation ofInto<Lcha>