Color migration guide #1379
Merged
Color migration guide #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: this should include migrations for bevyengine/bevy#12163, bevyengine/bevy#12079, bevyengine/bevy#12105, bevyengine/bevy#12116, bevyengine/bevy#12114, bevyengine/bevy#12115, bevyengine/bevy#12168, bevyengine/bevy#12583, and bevyengine/bevy#12399. |
viridia
approved these changes
Jun 9, 2024
gagnus
reviewed
Jun 9, 2024
| - `Color::set_a` and `Color::a` is now `Color::set_alpha` and `Color::alpha`. These are part of the `Alpha` trait in `bevy_color`. | ||
| - `Color::is_fully_transparent` is now part of the `Alpha` trait in `bevy_color` | ||
| - `Color::r`, `Color::set_r`, `Color::with_r` and the equivalents for `g`, `b` `h`, `s` and `l` have been removed due to causing silent relatively expensive conversions. Convert your `Color` into the desired color space, perform your operations there, and then convert it back into a polymorphic `Color` enum. | ||
| - `Color::hex` is now `Srgba::hex`. Call `.into` or construct a `Color::Srgba` variant manually to convert it. |
There was a problem hiding this comment.
What section are you referring to for this? You commented on removed text that no longer exists, so I'm not sure what you're talking about.
release-content/0.14/migration-guides/12163_Migrate_from_LegacyColor_to_bevy_colorColor.md
Outdated
Show resolved
Hide resolved
release-content/0.14/migration-guides/12163_Migrate_from_LegacyColor_to_bevy_colorColor.md
Outdated
Show resolved
Hide resolved
release-content/0.14/migration-guides/12163_Migrate_from_LegacyColor_to_bevy_colorColor.md
Outdated
Show resolved
Hide resolved
alice-i-cecile
approved these changes
Jun 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally part of #1376, but I split it out due to the amount of content.
This is the draft migration guide for the new color module. Please review it, re-organize it, and correct it as much as you like!