bevy_color: Add Laba to support Lab Color Model
#12115
Conversation
bushrat011899
added
C-Feature
|
The prerequisite PR has been merged :) Please rebase when you get a chance and we can add this in. |
bushrat011899
force-pushed
the
AddLab
branch
from
8396d32
to
754e3cf
Compare
Also added a couple of `macro_rules` definitions to automate highly repetitive definitions.
bushrat011899
force-pushed
the
AddLab
branch
from
754e3cf
to
d44ae60
Compare
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Yeah, I'd like to develop a bit of a map for the conversions in the crate level docs. That can be split out into another PR easily though. |
|
Also, I know we've been trying to explain to new users what all these various color spaces are for but at some point we will have to give up, because the distinctions are (a) hair-splitting and (b) historical, which makes it hard to write a clear and distinct explanation. |
|
I was thinking it might be nice to actually include a diagram showing how the various colour spaces relate to each other, but I'm not sure what the best way to include that in Rust Docs would be.
|
|
If we go that route, I'd recommend |
|
That's definitely the route I'd want to take. I'll make a little PR for this now |
# Objective - Improve compatibility with CSS Module 4 - Simplify `Lcha` conversion functions ## Solution - Added `Laba` which implements the Lab color model. - Updated `Color` and `LegacyColor` accordingly. ## Migration Guide - Convert `Laba` to either `Xyza` or `Lcha` using the provided `From` implementations and then handle accordingly. ## Notes The Lab color space is a required stepping stone when converting between XYZ and Lch, therefore we already use the Lab color model, just in an nameless fashion prone to errors. This PR also includes a slightly broader refactor of the `From` implementations between the various colour spaces to better reflect the graph of definitions. My goal was to keep domain specific knowledge of each colour space contained to their respective files (e.g., the `From<Oklaba> for LinearRgba` definition was in `linear_rgba.rs` when it probably belongs in `oklaba.rs`, since Linear sRGB is a fundamental space and Oklab is defined in its relation to it)
Objective
Lchaconversion functionsSolution
Labawhich implements the Lab color model.ColorandLegacyColoraccordingly.Migration Guide
Labato eitherXyzaorLchausing the providedFromimplementations and then handle accordingly.Notes
The Lab color space is a required stepping stone when converting between XYZ and Lch, therefore we already use the Lab color model, just in an nameless fashion prone to errors.
This PR also includes a slightly broader refactor of the
Fromimplementations between the various colour spaces to better reflect the graph of definitions. My goal was to keep domain specific knowledge of each colour space contained to their respective files (e.g., theFrom<Oklaba> for LinearRgbadefinition was inlinear_rgba.rswhen it probably belongs inoklaba.rs, since Linear sRGB is a fundamental space and Oklab is defined in its relation to it)