bevy_color: Add Oklch Color Space
#12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 27, 2024
|
Can you add matching constructors per #12171 please? |
alice-i-cecile
added
C-Feature
alice-i-cecile
approved these changes
Feb 28, 2024
bushrat011899
force-pushed
the
AddOklchaColorSpace
branch
from
abe6df8
to
75f57f2
Compare
viridia
approved these changes
Feb 28, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Oklchawhich implements the Oklch color model.ColorandLegacyColoraccordingly.Migration Guide
OklchatoOklabausing the providedFromimplementations and then handle accordingly.Notes
This is the last color space missing from the CSS Module 4 standard, and is also the one I believe we should recommend users actually work with for hand-crafting colours. It has all the uniformity benefits of Oklab combined with the intuition chroma and hue provide (when compared to a-axis and b-axis parameters).