-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative fix for mesh2d_manual
example
#15883
Alternative fix for mesh2d_manual
example
#15883
Conversation
mesh2d_manual
examplemesh2d_manual
example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this more than the alternative,
can confirm the example works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to demonstrate something actually custom. Thanks!
Why does the current code not work? AFAIK attributes haven't changed at all for a long time? |
@IceSentry It was mistake during the migration in #15862. During the process of figuring out why So the question right now is just "do we want to use a custom vertex attribute in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thank you for the context, in that case, yeah I'm happy to use a custom attribute here.
Objective
Fixes #15847
Alternative to #15862. Would appreciate a rendering person signaling preference for one or the other.
Solution
Partially revert the changes made to this example in #15524.
Add comment explaining that the non-usage of the built-in color vertex attribute is intentional.
Testing
cargo run --example mesh2d_manual