-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the detailed_trace macro #16450
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with removing this in the current broken form, especially since it's now breaking CI.
@mockersf you're missing some imports, as CI helpfully points out: https://github.com/bevyengine/bevy/actions/runs/11940939339/job/33284703598?pr=16450#step:6:749 |
Just linking those here for visibility: https://docs.rs/tracing/latest/tracing/level_filters/index.html#compile-time-filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does mean people need to remember to disable tracing (via compile time flags) or they will have significant performance degradation (even in release mode). I'm pretty worried that we'll be tanking performance by default now / a high percentage of games will ship with high-traffic / high cost trace logs. That being said, I do like the simplicity of just using normal log levels / removing this plumbing .
Actually hold on. Can we just fix the macro for 0.15? Maybe that would be better than rushing this in. It would be good to have a full cycle to evaluate the performance implications of this. |
In that case, I would prefer to remove those logs completely. They were not possible to enable through the feature, so no one should miss them |
I think we should discuss that as the permanent solution (ex: evaluate each log for value / do performance cost-benefit / decide the correct long term path for this category of thing). Imo we should minimally fix this for 0.15 without rocking the boat. It feels like removing logs indiscriminately is rocking the boat (even if they don't currently have users). |
Alternative to #16450 # Objective detailed_trace! in its current form does not work (and breaks CI) ## Solution Fix detailed_trace by checking for the feature properly, adding it to the correct crates, and removing it from the incorrect crates
Alternative to #16450 # Objective detailed_trace! in its current form does not work (and breaks CI) ## Solution Fix detailed_trace by checking for the feature properly, adding it to the correct crates, and removing it from the incorrect crates
Objective
Solution
detailed_trace
macro, and replace its use by thetrace
macrodetailed_trace
feature