Fix detailed_trace! #16452
Merged
Fix detailed_trace! #16452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
C-Bug
|
as mentioned in #16450, I think a better solution is to remove the macro and the logs that are using it |
alice-i-cecile
added
the
S-Needs-Review
|
I responded there |
alice-i-cecile
approved these changes
Nov 20, 2024
|
Merging now in the interest of unblocking main. If we decide removing is the move for 0.15, we can do that later |
mockersf
pushed a commit
that referenced
this pull request
Nov 22, 2024
Alternative to #16450 # Objective detailed_trace! in its current form does not work (and breaks CI) ## Solution Fix detailed_trace by checking for the feature properly, adding it to the correct crates, and removing it from the incorrect crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #16450
Objective
detailed_trace! in its current form does not work (and breaks CI)
Solution
Fix detailed_trace by checking for the feature properly, adding it to the correct crates, and removing it from the incorrect crates